From: Andy Grover <andy.grover@oracle.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, rds-devel@oss.oracle.com
Subject: Re: [RESEND PATCH] mm: Use spin_lock_irqsave in __set_page_dirty_nobuffers
Date: Fri, 21 Jan 2011 11:25:26 -0800 [thread overview]
Message-ID: <4D39DDA6.1080604@oracle.com> (raw)
In-Reply-To: <20110121001804.413b3f6d.akpm@linux-foundation.org>
On 01/21/2011 12:18 AM, Andrew Morton wrote:
> On Mon, 10 Jan 2011 22:15:34 -0800 Andy Grover<andy.grover@oracle.com> wrote:
>
>> RDS is calling set_page_dirty from interrupt context,
>
> yikes. Whatever possessed you to try that?
When doing an RDMA read into pinned pages, we get notified the operation
is complete in a tasklet, and would like to mark the pages dirty and
unpin in the same context.
The issue was __set_page_dirty_buffers (via calling set_page_dirty) was
unconditionally re-enabling irqs as a side-effect because it was using
*_irq instead of *_irqsave/restore.
How would you recommend we proceed? My understanding was calling
set_page_dirty prior to issuing the operation isn't an option since it
might get cleaned too early.
Thanks -- Regards -- Andy
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-01-21 19:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-11 6:15 [RESEND PATCH] mm: Use spin_lock_irqsave in __set_page_dirty_nobuffers Andy Grover
2011-01-21 8:18 ` Andrew Morton
2011-01-21 19:25 ` Andy Grover [this message]
2011-01-21 20:09 ` Andrew Morton
2011-01-25 1:30 ` Andy Grover
2011-01-25 1:44 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D39DDA6.1080604@oracle.com \
--to=andy.grover@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=rds-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).