linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Andi Kleen <ak@linux.intel.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Tim Chen <tim.c.chen@linux.intel.com>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC] mm: Make vm_acct_memory scalable for large memory allocations
Date: Thu, 27 Jan 2011 16:15:05 -0800	[thread overview]
Message-ID: <4D420A89.3050906@linux.intel.com> (raw)
In-Reply-To: <20110127153642.f022b51c.akpm@linux-foundation.org>


> This seems like a pretty dumb test case.  We have 64 cores sitting in a
> loop "allocating" 32MB of memory, not actually using that memory and
> then freeing it up again.
>
> Any not-completely-insane application would actually _use_ the memory.
> Which involves pagefaults, page allocations and much memory traffic
> modifying the page contents.
>
> Do we actually care?

It's a bit like a poorly tuned malloc. From what I heard poorly tuned 
mallocs are quite
common in the field, also with lots of custom ones around.

While it would be good to tune them better the kernel should also have 
reasonable performance
for this case.

The poorly tuned malloc has other problems too, but this addresses at 
least one
of them.

Also I think Tim's patch is a general improvement to a somewhat dumb 
code path.

-Andi

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2011-01-28  0:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-26 22:51 [RFC] mm: Make vm_acct_memory scalable for large memory allocations Tim Chen
2011-01-27 23:36 ` Andrew Morton
2011-01-28  0:15   ` Andi Kleen [this message]
2011-01-28  0:26     ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D420A89.3050906@linux.intel.com \
    --to=ak@linux.intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=tim.c.chen@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).