linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: "Alex Villací­s Lasso" <avillaci@fiec.espol.edu.ec>
To: Andrea Arcangeli <aarcange@redhat.com>
Cc: Mel Gorman <mel@csn.ul.ie>,
	Andrew Morton <akpm@linux-foundation.org>,
	avillaci@ceibo.fiec.espol.edu.ec,
	bugzilla-daemon@bugzilla.kernel.org,
	bugme-daemon@bugzilla.kernel.org, linux-mm@kvack.org
Subject: Re: [Bugme-new] [Bug 31142] New: Large write to USB stick freezes unrelated tasks for a long time
Date: Mon, 21 Mar 2011 10:36:16 -0500	[thread overview]
Message-ID: <4D877070.2000209@fiec.espol.edu.ec> (raw)
In-Reply-To: <4D876D43.3020409@fiec.espol.edu.ec>

El 21/03/11 10:22, Alex Villaci-s Lasso escribio:
> El 21/03/11 08:48, Andrea Arcangeli escribio:
>>
>> ===
>> Subject: mm: compaction: Use async migration for __GFP_NO_KSWAPD and enforce no writeback
>>
>> From: Andrea Arcangeli<aarcange@redhat.com>
>>
>> __GFP_NO_KSWAPD allocations are usually very expensive and not mandatory
>> to succeed as they have graceful fallback. Waiting for I/O in those, tends
>> to be overkill in terms of latencies, so we can reduce their latency by
>> disabling sync migrate.
>>
>> Unfortunately, even with async migration it's still possible for the
>> process to be blocked waiting for a request slot (e.g. get_request_wait
>> in the block layer) when ->writepage is called. To prevent __GFP_NO_KSWAPD
>> blocking, this patch prevents ->writepage being called on dirty page cache
>> for asynchronous migration.
>>
>> [mel@csn.ul.ie: Avoid writebacks for NFS, retry locked pages, use bool]
>> Signed-off-by: Andrea Arcangeli<aarcange@redhat.com>
>> Signed-off-by: Mel Gorman<mel@csn.ul.ie>
>> ---
>>   mm/migrate.c    |   48 +++++++++++++++++++++++++++++++++---------------
>>   mm/page_alloc.c |    2 +-
>>   2 files changed, 34 insertions(+), 16 deletions(-)
> The latest patch fails to apply in vanilla 2.6.38:
>
> [alex@srv64 linux-2.6.38]$ patch -p1 --dry-run < ../\[Bug\ 31142\]\ Large\ write\ to\ USB\ stick\ freezes\ unrelated\ tasks\ for\ a\ long\ time.eml
> (Stripping trailing CRs from patch.)
> patching file mm/migrate.c
> Hunk #1 FAILED at 564.
> Hunk #2 FAILED at 586.
> Hunk #3 FAILED at 641.
> Hunk #4 FAILED at 686.
> Hunk #5 FAILED at 757.
> Hunk #6 FAILED at 850.
> 6 out of 6 hunks FAILED -- saving rejects to file mm/migrate.c.rej
> (Stripping trailing CRs from patch.)
> patching file mm/page_alloc.c
> Hunk #1 FAILED at 2085.
> 1 out of 1 hunk FAILED -- saving rejects to file mm/page_alloc.c.rej
>
> I will try to apply the patch manually.
>
After some massaging, I succeeded in applying the patch. Compiling now.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2011-03-21 15:37 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bug-31142-10286@https.bugzilla.kernel.org/>
2011-03-15 20:53 ` [Bugme-new] [Bug 31142] New: Large write to USB stick freezes unrelated tasks for a long time Andrew Morton
2011-03-15 22:53   ` Alex Villací­s Lasso
2011-03-15 23:19     ` Andrew Morton
2011-03-16 15:25       ` Alex Villací­s Lasso
2011-03-16 22:02         ` Andrew Morton
2011-03-17 21:27           ` Alex Villací­s Lasso
2011-03-17 21:47             ` Andrew Morton
2011-03-17 22:11               ` Alex Villací­s Lasso
2011-03-17 22:25                 ` Andrew Morton
2011-03-18 11:13               ` Mel Gorman
2011-03-18 12:26                 ` Andrea Arcangeli
2011-03-18 18:05                 ` Alex Villací­s Lasso
2011-03-19 13:46                   ` Mel Gorman
2011-03-19 16:04                     ` Alex Villací­s Lasso
2011-03-19 23:51                       ` Andrea Arcangeli
2011-03-21  9:41                         ` Mel Gorman
2011-03-21 13:48                           ` Andrea Arcangeli
2011-03-21 15:22                             ` Alex Villací­s Lasso
2011-03-21 15:36                               ` Alex Villací­s Lasso [this message]
2011-03-21 15:40                               ` Andrea Arcangeli
2011-03-21 16:37                             ` Mel Gorman
2011-03-21 17:05                               ` Alex Villací­s Lasso
2011-03-21 20:16                                 ` Andrea Arcangeli
2011-03-21 23:35                                   ` Alex Villací­s Lasso
2011-03-22 11:20                                   ` Mel Gorman
2011-03-22 15:03                                     ` Andrea Arcangeli
2011-03-22 20:34                                       ` Alex Villací­s Lasso
2011-03-22 21:40                                         ` Andrea Arcangeli
2011-03-23  0:37                                           ` Andrea Arcangeli
2011-03-23 16:51                                             ` Alex Villací­s Lasso
2011-04-04 15:37                                               ` Alex Villací­s Lasso
2011-04-08 19:09                                                 ` Andrea Arcangeli
2011-04-08 20:06                                                   ` Alex Villací­s Lasso
2011-04-12 16:27                                                     ` Alex Villací­s Lasso
2011-04-14 17:25                                                       ` Alex Villací­s Lasso
2011-04-14 17:37                                                         ` Andrea Arcangeli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D877070.2000209@fiec.espol.edu.ec \
    --to=avillaci@fiec.espol.edu.ec \
    --cc=aarcange@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=avillaci@ceibo.fiec.espol.edu.ec \
    --cc=bugme-daemon@bugzilla.kernel.org \
    --cc=bugzilla-daemon@bugzilla.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mel@csn.ul.ie \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).