From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail144.messagelabs.com (mail144.messagelabs.com [216.82.254.51]) by kanga.kvack.org (Postfix) with ESMTP id BC477900001 for ; Fri, 29 Apr 2011 10:17:44 -0400 (EDT) Message-ID: <4DBAC85D.50306@freescale.com> Date: Fri, 29 Apr 2011 09:17:01 -0500 From: Timur Tabi MIME-Version: 1.0 Subject: Re: [PATCH 1/3] rename alloc_pages_exact() References: <20110414200139.ABD98551@kernel> In-Reply-To: <20110414200139.ABD98551@kernel> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Dave Hansen Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andi Kleen , Mel Gorman , Andrew Morton , Michal Nazarewicz , David Rientjes Dave Hansen wrote: > alloc_pages_exact() returns a virtual address. But, alloc_pages() returns > a 'struct page *'. That makes for very confused kernel hackers. > > __get_free_pages(), on the other hand, returns virtual addresses. That > makes alloc_pages_exact() a much closer match to __get_free_pages(), so > rename it to get_free_pages_exact(). Also change the arguments to have > flags first, just like __get_free_pages(). > > Note that alloc_pages_exact()'s partner, free_pages_exact() already > matches free_pages(), so we do not have to touch the free side of things. > > Signed-off-by: Dave Hansen > Acked-by: Andi Kleen > Acked-by: David Rientjes All three patches: Acked-by: Timur Tabi -- Timur Tabi Linux kernel developer at Freescale -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org