Re: [PATCH 1/1] coredump: use task comm instead of (unknown)

Andrew Morton
2011-05-05T22:06:11Z

On Wed, 4 May 2011 09:32:34 +0200
Jiri Slaby <jslaby@suse.cz> wrote:

> If we don't know the file corresponding to the binary (i.e. exe_file
> is unknown), use "task->comm (path unknown)" instead of simple
> "(unknown)" as suggested by ak.
>
> The fallback is the same as %e except it will append "(path unknown)".
>
> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
> Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
> Cc: Al Viro <viro@zeniv.linux.org.uk>
> Cc: Andi Kleen <andi@firstfloor.org>
> ---
> fs/exec.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/exec.c b/fs/exec.c
> index 5ee7562..0a4d281 100644
> --- a/fs/exec.c
> +++ b/fs/exec.c
> @@ -1555,7 +1555,7 @@ static int cn_print_exe_file(struct core_name *cn)
>
> exe_file = get_mm_exe_file(current->mm);
> if (!exe_file)
> - return cn_printf(cn, "(unknown)");
> + return cn_printf(cn, "%s (path unknown)", current->comm);
>
> pathbuf = kmalloc(PATH_MAX, GFP_TEMPORARY);
> if (!pathbuf) {

Direct access to current->comm is racy since we added
prctl(PR_SET_NAME).

Hopefully John Stultz will soon be presenting us with a %p modifier for
displaying task_struct.comm.

But we should get this settled pretty promptly as this is a form of
userspace-visible API. Use get_task_comm() for now.

Also, there's nothing which prevents userspace from rewriting
task->comm to something which contains slashes (this seems bad). If
that is done, your patch will do Bad Things - it should be modified to
use cn_print_exe_file()'s slash-overwriting codepath.