From: Cong Wang <amwang@redhat.com>
To: David Rientjes <rientjes@google.com>
Cc: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
dave@linux.vnet.ibm.com, Andrea Arcangeli <aarcange@redhat.com>,
Mel Gorman <mel@csn.ul.ie>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Rik van Riel <riel@redhat.com>,
Johannes Weiner <hannes@cmpxchg.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
linux-mm@kvack.org
Subject: Re: [PATCH v2 2/4] mm: make the threshold of enabling THP configurable
Date: Wed, 22 Jun 2011 13:40:48 +0800 [thread overview]
Message-ID: <4E018060.3050607@redhat.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1106212024210.8712@chino.kir.corp.google.com>
ao? 2011a1'06ae??22ae?JPY 11:29, David Rientjes a??e??:
>
> Either way, this patch isn't needed since it has no benefit over doing it
> through an init script.
If you were right, CONFIG_TRANSPARENT_HUGEPAGE_ALWAYS is not needed,
you can do it through an init script.
If you were right, the 512M limit is not needed neither, you have
transparent_hugepage=never boot parameter and do the check of
512M later in an init script. (Actually, moving the 512M check to
user-space is really more sane to me.)
I am quite sure you have lots of other things which both have a Kconfig
and a boot parameter, why do we have it?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-06-22 5:41 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-21 8:10 [PATCH v2 1/4] mm: completely disable THP by transparent_hugepage=0 Amerigo Wang
2011-06-21 8:10 ` [PATCH v2 2/4] mm: make the threshold of enabling THP configurable Amerigo Wang
2011-06-21 14:44 ` Dave Hansen
2011-06-21 20:17 ` Dave Hansen
2011-06-22 1:23 ` David Rientjes
2011-06-22 3:06 ` Cong Wang
2011-06-22 3:29 ` David Rientjes
2011-06-22 5:40 ` Cong Wang [this message]
2011-06-22 6:32 ` David Rientjes
2011-06-22 11:07 ` Cong Wang
2011-06-22 14:40 ` Andrea Arcangeli
2011-06-23 6:51 ` Cong Wang
2011-06-21 8:10 ` [PATCH 3/4] mm: improve THP printk messages Amerigo Wang
2011-06-22 1:23 ` David Rientjes
2011-06-22 3:04 ` Cong Wang
2011-06-21 8:10 ` [PATCH 4/4] mm: introduce no_ksm to disable totally KSM Amerigo Wang
2011-06-21 13:32 ` Andrea Arcangeli
2011-06-22 3:13 ` Cong Wang
2011-06-21 11:52 ` [PATCH v2 1/4] mm: completely disable THP by transparent_hugepage=0 Michal Hocko
2011-06-21 11:58 ` Michal Hocko
2011-06-21 13:30 ` Andrea Arcangeli
2011-06-22 3:11 ` Cong Wang
2011-06-22 1:16 ` David Rientjes
2011-06-22 3:08 ` Cong Wang
2011-06-22 3:24 ` David Rientjes
2011-06-22 5:45 ` Cong Wang
2011-06-22 6:23 ` David Rientjes
2011-06-22 11:08 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E018060.3050607@redhat.com \
--to=amwang@redhat.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=dave@linux.vnet.ibm.com \
--cc=hannes@cmpxchg.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=riel@redhat.com \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).