From: David Daney <ddaney.cavm@gmail.com>
To: Christoph Lameter <cl@linux.com>
Cc: Marcin Slusarz <marcin.slusarz@gmail.com>,
Pekka Enberg <penberg@kernel.org>, Matt Mackall <mpm@selenic.com>,
LKML <linux-kernel@vger.kernel.org>,
linux-mm@kvack.org
Subject: Re: [PATCH] slub: reduce overhead of slub_debug
Date: Tue, 28 Jun 2011 12:40:22 -0700 [thread overview]
Message-ID: <4E0A2E26.5000001@gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1106281431370.27518@router.home>
On 06/28/2011 12:32 PM, Christoph Lameter wrote:
> On Sun, 26 Jun 2011, Marcin Slusarz wrote:
>
>> slub checks for poison one byte by one, which is highly inefficient
>> and shows up frequently as a highest cpu-eater in perf top.
>
> Ummm.. Performance improvements for debugging modes? If you need
> performance then switch off debuggin.
There is no reason to make things gratuitously slow. I don't know about
the merits of this particular patch, but I must disagree with the
general sentiment.
We have high performance tracing, why not improve this as well.
Just last week I was trying to find the cause of memory corruption that
only occurred at very high network packet rates. Memory allocation
speed was definitely getting in the way of debugging. For me, faster
SLUB debugging would be welcome.
David Daney
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-06-28 19:40 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-26 19:39 [PATCH] slub: reduce overhead of slub_debug Marcin Slusarz
2011-06-28 19:32 ` Christoph Lameter
2011-06-28 19:40 ` David Daney [this message]
2011-06-28 20:58 ` David Rientjes
2011-06-28 21:04 ` Ben Greear
2011-06-28 21:10 ` David Rientjes
2011-06-28 21:16 ` Dave Jones
2011-07-07 18:07 ` Pekka Enberg
2011-07-07 18:17 ` Christoph Lameter
2011-07-07 18:30 ` Ben Greear
2011-07-07 18:42 ` Christoph Lameter
2011-07-07 18:54 ` Ben Greear
2011-07-07 18:30 ` Matt Mackall
2011-07-07 18:52 ` Pekka Enberg
2011-07-07 18:55 ` Matt Mackall
2011-07-07 19:12 ` Christoph Lameter
2011-07-07 19:21 ` David Miller
2011-07-07 19:49 ` Pekka Enberg
2011-07-07 20:12 ` Christoph Lameter
2011-07-08 5:23 ` Andi Kleen
2011-07-08 17:41 ` Christoph Lameter
2011-07-08 5:38 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E0A2E26.5000001@gmail.com \
--to=ddaney.cavm@gmail.com \
--cc=cl@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=marcin.slusarz@gmail.com \
--cc=mpm@selenic.com \
--cc=penberg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).