From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: rientjes@google.com
Cc: akpm@linux-foundation.org, kamezawa.hiroyu@jp.fujitsu.com,
linux-mm@kvack.org
Subject: Re: [patch] oom: avoid killing kthreads if they assume the oom killed thread's mm
Date: Wed, 27 Jul 2011 09:35:41 +0900 [thread overview]
Message-ID: <4E2F5D5D.10901@jp.fujitsu.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1107251711460.26480@chino.kir.corp.google.com>
(2011/07/26 9:12), David Rientjes wrote:
> After selecting a task to kill, the oom killer iterates all processes and
> kills all other threads that share the same mm_struct in different thread
> groups. It would not otherwise be helpful to kill a thread if its memory
> would not be subsequently freed.
>
> A kernel thread, however, may assume a user thread's mm by using
> use_mm(). This is only temporary and should not result in sending a
> SIGKILL to that kthread.
>
> This patch ensures that only user threads and not kthreads are sent a
> SIGKILL if they share the same mm_struct as the oom killed task.
>
> Signed-off-by: David Rientjes <rientjes@google.com>
Looks good.
Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2011-07-27 0:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-26 0:12 [patch] oom: avoid killing kthreads if they assume the oom killed thread's mm David Rientjes
2011-07-26 15:27 ` Michal Hocko
2011-07-26 22:05 ` David Rientjes
2011-07-27 7:59 ` Michal Hocko
2011-07-27 0:35 ` KOSAKI Motohiro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E2F5D5D.10901@jp.fujitsu.com \
--to=kosaki.motohiro@jp.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-mm@kvack.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).