From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail144.messagelabs.com (mail144.messagelabs.com [216.82.254.51]) by kanga.kvack.org (Postfix) with ESMTP id E5CC46B0174 for ; Thu, 11 Aug 2011 04:41:13 -0400 (EDT) Received: from d23relay04.au.ibm.com (d23relay04.au.ibm.com [202.81.31.246]) by e23smtp05.au.ibm.com (8.14.4/8.13.1) with ESMTP id p7B8YYO7003415 for ; Thu, 11 Aug 2011 18:34:34 +1000 Received: from d23av01.au.ibm.com (d23av01.au.ibm.com [9.190.234.96]) by d23relay04.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p7B8e8Hr1163280 for ; Thu, 11 Aug 2011 18:40:08 +1000 Received: from d23av01.au.ibm.com (loopback [127.0.0.1]) by d23av01.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p7B8f5xr013268 for ; Thu, 11 Aug 2011 18:41:06 +1000 Message-ID: <4E43959D.9000803@linux.vnet.ibm.com> Date: Thu, 11 Aug 2011 14:11:01 +0530 From: Raghavendra K T MIME-Version: 1.0 Subject: Re: [PATCH 0/2][cleanup] memcg: renaming of mem variable to memcg References: <20110810172917.23280.9440.sendpatchset@oc5400248562.ibm.com> <20110811075337.GA8023@tiehlicka.suse.cz> <4E438FD3.7070000@linux.vnet.ibm.com> <20110811082641.GD8023@tiehlicka.suse.cz> In-Reply-To: <20110811082641.GD8023@tiehlicka.suse.cz> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Michal Hocko Cc: Raghavendra K T , Arend van Spriel , Greg Kroah-Hartman , "David S. Miller" , "nishimura@mxp.nes.nec.co.jp" , Balbir Singh , "John W. Linville" , Mauro Carvalho Chehab , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Ying Han , Andrew Morton , KAMEZAWA Hiroyuki , Srivatsa Vaddagiri On 08/11/2011 01:56 PM, Michal Hocko wrote: > On Thu 11-08-11 13:46:19, Raghavendra K T wrote: >> On 08/11/2011 01:23 PM, Michal Hocko wrote: >>> On Wed 10-08-11 22:59:17, Raghavendra K T wrote: >>>> Hi, >>>> This is the memcg cleanup patch for that was talked little ago to change the "struct >>>> mem_cgroup *mem" variable to "struct mem_cgroup *memcg". >>>> >>>> The patch is though trivial, it is huge one. >>>> Testing : Compile tested with following configurations. >>>> 1) CONFIG_CGROUP_MEM_RES_CTLR=y CONFIG_CGROUP_MEM_RES_CTLR_SWAP=y >>>> 2) CONFIG_CGROUP_MEM_RES_CTLR=y CONFIG_CGROUP_MEM_RES_CTLR_SWAP=n >>>> 3) CONFIG_CGROUP_MEM_RES_CTLR=n CONFIG_CGROUP_MEM_RES_CTLR_SWAP=n >>> >>> How exactly have you tested? Compiled and compared before/after binaries >>> (it shouldn't change, right)? >> Yes, But idea was to ensure that both #ifdef and #else part are hit >> during compilation, which could expose some corrections needed. > > I am not sure I understand. You have used different combinations of > configuration to trigger all #ifdefs but that doesn't change anything on > the fact that the code should be exactly same before and after your > patch, right? > Yes you are right again. No change in the code after the patch. It was just to exercise I have not missed any valid changes in both paths, and it does not break compilation. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org