From: Raghavendra K T <raghukt@linux.vnet.ibm.com>
To: Michal Hocko <mhocko@suse.cz>
Cc: Raghavendra K T <raghavendra.kt@linux.vnet.ibm.com>,
Arend van Spriel <arend@broadcom.com>,
Greg Kroah-Hartman <gregkh@suse.de>,
"David S. Miller" <davem@davemloft.net>,
"nishimura@mxp.nes.nec.co.jp" <nishimura@mxp.nes.nec.co.jp>,
Balbir Singh <bsingharora@gmail.com>,
"John W. Linville" <linville@tuxdriver.com>,
Mauro Carvalho Chehab <mchehab@redhat.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Ying Han <yinghan@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Srivatsa Vaddagiri <vatsa@linux.vnet.ibm.com>
Subject: Re: [PATCH 1/2][cleanup] memcg: renaming of mem variable to memcg
Date: Thu, 11 Aug 2011 14:27:06 +0530 [thread overview]
Message-ID: <4E439962.4040105@linux.vnet.ibm.com> (raw)
In-Reply-To: <20110811080447.GB8023@tiehlicka.suse.cz>
On 08/11/2011 01:34 PM, Michal Hocko wrote:
> On Wed 10-08-11 22:59:29, Raghavendra K T wrote:
> [...]
>> This patch renames all mem variables to memcg in source file.
>
> __mem_cgroup_try_charge for example uses local mem which cannot be
> renamed because it already has a memcg argument (mem_cgroup **) then we
> have mem_cgroup_try_charge_swapin and mem_cgroup_prepare_migration which
> use mem_cgroup **ptr (I guess we shouldn't have more of them).
> I think that __mem_cgroup_try_charge should use ptr pattern as well.
> Other than that I think the clean up is good.
>
> With __mem_cgroup_try_charge:
> Acked-by: Michal Hocko<mhocko@suse.cz>
>
> Thanks
Agreed, Let me know whether you prefer whole patch to be posted or only
the corresponding hunk.
Thanks
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-08-11 8:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-10 17:29 [PATCH 0/2][cleanup] memcg: renaming of mem variable to memcg Raghavendra K T
2011-08-10 17:29 ` [PATCH 1/2][cleanup] " Raghavendra K T
2011-08-10 23:58 ` KAMEZAWA Hiroyuki
2011-08-11 8:04 ` Michal Hocko
2011-08-11 8:57 ` Raghavendra K T [this message]
2011-08-11 9:03 ` Michal Hocko
2011-08-12 6:59 ` Raghavendra K T
2011-08-10 17:29 ` [PATCH 2/2][cleanup] " Raghavendra K T
2011-08-10 23:59 ` KAMEZAWA Hiroyuki
2011-08-11 8:05 ` Michal Hocko
2011-08-11 8:21 ` Raghavendra K T
2011-08-11 7:53 ` [PATCH 0/2][cleanup] " Michal Hocko
2011-08-11 8:16 ` Raghavendra K T
2011-08-11 8:26 ` Michal Hocko
2011-08-11 8:41 ` Raghavendra K T
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E439962.4040105@linux.vnet.ibm.com \
--to=raghukt@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=arend@broadcom.com \
--cc=bsingharora@gmail.com \
--cc=davem@davemloft.net \
--cc=gregkh@suse.de \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linville@tuxdriver.com \
--cc=mchehab@redhat.com \
--cc=mhocko@suse.cz \
--cc=nishimura@mxp.nes.nec.co.jp \
--cc=raghavendra.kt@linux.vnet.ibm.com \
--cc=vatsa@linux.vnet.ibm.com \
--cc=yinghan@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).