From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail143.messagelabs.com (mail143.messagelabs.com [216.82.254.35]) by kanga.kvack.org (Postfix) with SMTP id 6ADA36B00EE for ; Thu, 11 Aug 2011 11:57:55 -0400 (EDT) Message-ID: <4E43FBF0.1010607@redhat.com> Date: Thu, 11 Aug 2011 11:57:36 -0400 From: Rik van Riel MIME-Version: 1.0 Subject: Re: [PATCH 1/7] mm: vmscan: Do not writeback filesystem pages in direct reclaim References: <1312973240-32576-1-git-send-email-mgorman@suse.de> <1312973240-32576-2-git-send-email-mgorman@suse.de> In-Reply-To: <1312973240-32576-2-git-send-email-mgorman@suse.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Mel Gorman Cc: Linux-MM , LKML , XFS , Dave Chinner , Christoph Hellwig , Johannes Weiner , Wu Fengguang , Jan Kara , Minchan Kim On 08/10/2011 06:47 AM, Mel Gorman wrote: > From: Mel Gorman > > When kswapd is failing to keep zones above the min watermark, a process > will enter direct reclaim in the same manner kswapd does. If a dirty > page is encountered during the scan, this page is written to backing > storage using mapping->writepage. > > This causes two problems. First, it can result in very deep call > stacks, particularly if the target storage or filesystem are complex. > Some filesystems ignore write requests from direct reclaim as a result. > The second is that a single-page flush is inefficient in terms of IO. > While there is an expectation that the elevator will merge requests, > this does not always happen. Quoting Christoph Hellwig; > > The elevator has a relatively small window it can operate on, > and can never fix up a bad large scale writeback pattern. > > This patch prevents direct reclaim writing back filesystem pages by > checking if current is kswapd. Anonymous pages are still written to > swap as there is not the equivalent of a flusher thread for anonymous > pages. If the dirty pages cannot be written back, they are placed > back on the LRU lists. There is now a direct dependency on dirty page > balancing to prevent too many pages in the system being dirtied which > would prevent reclaim making forward progress. > > Signed-off-by: Mel Gorman > Reviewed-by: Minchan Kim Reviewed-by: Rik van Riel -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org