Re: [PATCH V10 3/6] mm: frontswap: core frontswap functionality

[Seth Jennings <sjenning@linux.vnet.ibm.com>]

On 09/15/2011 04:34 PM, Dan Magenheimer wrote:
> From: Dan Magenheimer <dan.magenheimer@oracle.com>
> Subject: [PATCH V10 3/6] mm: frontswap: core frontswap functionality
> 
> (Note to earlier reviewers:  This patchset has been reorganized due to
> feedback from Kame Hiroyuki and Andrew Morton. This patch contains part
> of patch 3of4 from the previous series.)
> 
> This third patch of six in the frontswap series provides the core
> frontswap code that interfaces between the hooks in the swap subsystem
> and a frontswap backend via frontswap_ops.
> 
> [v10: sjenning@linux.vnet.ibm.com: fix debugfs calls on 32-bit]
...
> +#ifdef CONFIG_DEBUG_FS
> +	struct dentry *root = debugfs_create_dir("frontswap", NULL);
> +	if (root == NULL)
> +		return -ENXIO;
> +	debugfs_create_u64("gets", S_IRUGO, root, &frontswap_gets);
> +	debugfs_create_u64("succ_puts", S_IRUGO, root, &frontswap_succ_puts);
> +	debugfs_create_u64("puts", S_IRUGO, root, &frontswap_failed_puts);

Sorry I didn't see this one before :-/  This should be "failed_puts",
not "puts".

Other than that, it compiles cleanly here and runs without issue when
applied on 3.1-rc4 + fix for cleancache crash.

Thanks
--
Seth

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>