linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@xenotime.net>
To: Wizard <wizarddewhite@gmail.com>
Cc: linux-kernel@vger.kernel.org, kamezawa.hiroyu@jp.fujitsu.com,
	linux-mm@kvack.org
Subject: Re: [PATCH]   fix find_next_system_ram comments
Date: Mon, 26 Sep 2011 09:58:55 -0700	[thread overview]
Message-ID: <4E80AF4F.1030706@xenotime.net> (raw)
In-Reply-To: <1317045482-3355-1-git-send-email-wizarddewhite@gmail.com>

On 09/26/2011 06:58 AM, Wizard wrote:
> The purpose of find_next_system_ram() is to find a the lowest
> memory resource which contain or overlap the [res->start, res->end),
> not just contain.
> 
> In this patch, I make this comment more exact and fix one typo.
> 
> Signed-off-by: Wizard <wizarddewhite@gmail.com>

For Signed-off-by: Documentation/SubmittingPatches says:

using your real name (sorry, no pseudonyms or anonymous contributions.)

> ---
>  kernel/resource.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/kernel/resource.c b/kernel/resource.c
> index 3b3cedc..2751a8c 100644
> --- a/kernel/resource.c
> +++ b/kernel/resource.c
> @@ -279,7 +279,8 @@ EXPORT_SYMBOL(release_resource);
>  
>  #if !defined(CONFIG_ARCH_HAS_WALK_MEMORY)
>  /*
> - * Finds the lowest memory reosurce exists within [res->start.res->end)
> + * Finds the lowest memory resource which contains or overlaps
> + * [res->start.res->end)

Your patch description uses ", " (comma) here.  I think that's better than
keeping the ".".

>   * the caller must specify res->start, res->end, res->flags and "name".
>   * If found, returns 0, res is overwritten, if not found, returns -1.
>   */


-- 
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2011-09-26 16:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-26 13:58 [PATCH] fix find_next_system_ram comments Wizard
2011-09-26 16:58 ` Randy Dunlap [this message]
2011-09-28  0:52 ` KAMEZAWA Hiroyuki
  -- strict thread matches above, loose matches on Subject: below --
2011-09-27 14:02 Wizard
2011-09-28  4:36 ` KAMEZAWA Hiroyuki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E80AF4F.1030706@xenotime.net \
    --to=rdunlap@xenotime.net \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=wizarddewhite@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).