From: "H. Peter Anvin" <hpa@zytor.com>
To: Dave Hansen <dave@linux.vnet.ibm.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
rientjes@google.com, James.Bottomley@HansenPartnership.com
Subject: Re: [RFCv2][PATCH 1/4] break units out of string_get_size()
Date: Fri, 30 Sep 2011 14:29:55 -0700 [thread overview]
Message-ID: <4E8634D3.2080504@zytor.com> (raw)
In-Reply-To: <20110930203219.60D507CB@kernel>
On 09/30/2011 01:32 PM, Dave Hansen wrote:
> I would like to use these (well one of them) arrays in
> another function. Might as well break both versions
> out for consistency.
>
> Signed-off-by: Dave Hansen <dave@linux.vnet.ibm.com>
> ---
>
> linux-2.6.git-dave/lib/string_helpers.c | 25 +++++++++++++------------
> 1 file changed, 13 insertions(+), 12 deletions(-)
>
> diff -puN lib/string_helpers.c~string_get_size-pow2 lib/string_helpers.c
>
> +const char *units_10[] = { "B", "kB", "MB", "GB", "TB", "PB",
> + "EB", "ZB", "YB", NULL};
> +const char *units_2[] = {"B", "KiB", "MiB", "GiB", "TiB", "PiB",
> + "EiB", "ZiB", "YiB", NULL };
These names are way too generic to be public symbols.
Another thing worth thinking about is whether or not the -B suffix
should be part of these arrays.
-hpa
--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-09-30 21:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-30 20:32 [RFCv2][PATCH 1/4] break units out of string_get_size() Dave Hansen
2011-09-30 20:32 ` [RFCv2][PATCH 2/4] add string_get_size_pow2() Dave Hansen
2011-09-30 20:32 ` [RFCv2][PATCH 3/4] add seq_print_pow2() function Dave Hansen
2011-09-30 20:32 ` [RFCv2][PATCH 4/4] show page size in /proc/$pid/numa_maps Dave Hansen
2011-09-30 21:29 ` H. Peter Anvin [this message]
2011-09-30 22:46 ` [RFCv2][PATCH 1/4] break units out of string_get_size() Dave Hansen
2011-09-30 22:47 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E8634D3.2080504@zytor.com \
--to=hpa@zytor.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=dave@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).