From: Rik van Riel <riel@redhat.com>
To: Mel Gorman <mgorman@suse.de>
Cc: Johannes Weiner <hannes@cmpxchg.org>,
akpm@linux-foundation.org, Josh Boyer <jwboyer@redhat.com>,
aarcange@redhat.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] mm: Abort reclaim/compaction if compaction can proceed
Date: Fri, 07 Oct 2011 16:07:06 -0400 [thread overview]
Message-ID: <4E8F5BEA.3040502@redhat.com> (raw)
In-Reply-To: <1318000643-27996-3-git-send-email-mgorman@suse.de>
On 10/07/2011 11:17 AM, Mel Gorman wrote:
> If compaction can proceed, shrink_zones() stops doing any work but
> the callers still shrink_slab(), raises the priority and potentially
> sleeps. This patch aborts direct reclaim/compaction entirely if
> compaction can proceed.
>
> Signed-off-by: Mel Gorman<mgorman@suse.de>
This patch makes sense to me, but I have not tested it like
the first one.
Mel, have you tested this patch? Did you see any changed
behaviour vs. just the first patch?
Having said that, I'm pretty sure the patch is ok :)
--
All rights reversed
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-10-07 20:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-07 15:17 [PATCH 0/2] Avoid excessive reclaim due to THP Mel Gorman
2011-10-07 15:17 ` [PATCH 1/2] mm: vmscan: Limit direct reclaim for higher order allocations Mel Gorman
2011-10-07 19:32 ` Rik van Riel
2011-10-07 20:18 ` Mel Gorman
2011-10-09 8:02 ` Minchan Kim
2011-10-07 15:17 ` [PATCH 2/2] mm: Abort reclaim/compaction if compaction can proceed Mel Gorman
2011-10-07 20:07 ` Rik van Riel [this message]
2011-10-07 20:24 ` Mel Gorman
2011-10-07 22:42 ` Rik van Riel
2011-10-09 8:04 ` Minchan Kim
2011-10-12 14:57 ` Johannes Weiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E8F5BEA.3040502@redhat.com \
--to=riel@redhat.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=jwboyer@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).