From: Jens Axboe <axboe@kernel.dk>
To: David Rientjes <rientjes@google.com>
Cc: Mike Snitzer <snitzer@redhat.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Vivek Goyal <vgoyal@redhat.com>, Dave Young <dyoung@redhat.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
kexec@lists.infradead.org, stable@vger.kernel.org
Subject: Re: [patch v2 for-3.2] block: initialize request_queue's numa node during allocation
Date: Wed, 23 Nov 2011 10:59:35 +0100 [thread overview]
Message-ID: <4ECCC407.3040700@kernel.dk> (raw)
In-Reply-To: <alpine.DEB.2.00.1111221703590.18644@chino.kir.corp.google.com>
On 2011-11-23 02:14, David Rientjes wrote:
> From: Mike Snitzer <snitzer@redhat.com>
>
> struct request_queue is allocated with __GFP_ZERO so its "node" field is
> zero before initialization. This causes an oops if node 0 is offline in
> the page allocator because its zonelists are not initialized. From Dave
> Young's dmesg:
>
> SRAT: Node 1 PXM 2 0-d0000000
> SRAT: Node 1 PXM 2 100000000-330000000
> SRAT: Node 0 PXM 1 330000000-630000000
> Initmem setup node 1 0000000000000000-000000000affb000
> ...
> Built 1 zonelists in Node order, mobility grouping on.
> ...
> BUG: unable to handle kernel paging request at 0000000000001c08
> IP: [<ffffffff8111c355>] __alloc_pages_nodemask+0xb5/0x870
>
> and __alloc_pages_nodemask+0xb5 translates to a NULL pointer on
> zonelist->_zonerefs.
>
> The fix is to initialize q->node at the time of allocation so the correct
> node is passed to the slab allocator later.
>
> Since blk_init_allocated_queue_node() is no longer needed, merge it with
> blk_init_allocated_queue().
Thanks, queued for current release.
--
Jens Axboe
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-11-23 9:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-22 8:25 BUG: zonelist->_zonerefs == 0x1c08 Dave Young
2011-11-22 8:29 ` Dave Young
2011-11-22 10:00 ` David Rientjes
2011-11-22 15:27 ` Vivek Goyal
2011-11-22 21:19 ` [PATCH] block: initialize request_queue's numa node during allocation Mike Snitzer
2011-11-22 21:32 ` Vivek Goyal
2011-11-22 21:45 ` David Rientjes
2011-11-22 22:02 ` Mike Snitzer
2011-11-23 1:14 ` [patch v2 for-3.2] " David Rientjes
2011-11-23 1:39 ` Dave Young
2011-11-23 9:59 ` Jens Axboe [this message]
2011-11-22 22:13 ` Mike Snitzer
2011-11-23 1:23 ` BUG: zonelist->_zonerefs == 0x1c08 Dave Young
2011-11-23 2:05 ` Dave Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ECCC407.3040700@kernel.dk \
--to=axboe@kernel.dk \
--cc=dyoung@redhat.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rientjes@google.com \
--cc=snitzer@redhat.com \
--cc=stable@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).