From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail144.messagelabs.com (mail144.messagelabs.com [216.82.254.51]) by kanga.kvack.org (Postfix) with ESMTP id 63D316B004D for ; Tue, 29 Nov 2011 13:03:51 -0500 (EST) Received: by ghrr17 with SMTP id r17so8874991ghr.14 for ; Tue, 29 Nov 2011 10:03:47 -0800 (PST) Message-ID: <4ED51E81.3040304@gmail.com> Date: Tue, 29 Nov 2011 10:03:45 -0800 From: David Daney MIME-Version: 1.0 Subject: Re: [PATCH 3/3] MIPS: changes in VM core for adding THP References: <20111126173151.GF8397@redhat.com> <4ED51B48.6020202@redhat.com> In-Reply-To: <4ED51B48.6020202@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Rik van Riel Cc: Andrea Arcangeli , Hillf Danton , Andrew Morton , Ralf Baechle , linux-mips@linux-mips.org, linux-mm@kvack.org On 11/29/2011 09:50 AM, Rik van Riel wrote: > On 11/26/2011 12:31 PM, Andrea Arcangeli wrote: >> On Sat, Nov 26, 2011 at 10:43:15PM +0800, Hillf Danton wrote: >>> In VM core, window is opened for MIPS to use THP. >>> >>> And two simple helper functions are added to easy MIPS a bit. >>> >>> Signed-off-by: Hillf Danton >>> --- >>> >>> --- a/mm/Kconfig Thu Nov 24 21:12:00 2011 >>> +++ b/mm/Kconfig Sat Nov 26 22:12:56 2011 >>> @@ -307,7 +307,7 @@ config NOMMU_INITIAL_TRIM_EXCESS >>> >>> config TRANSPARENT_HUGEPAGE >>> bool "Transparent Hugepage Support" >>> - depends on X86&& MMU >>> + depends on MMU >>> select COMPACTION >>> help >>> Transparent Hugepages allows the kernel to use huge pages and >> >> Then the build will break for all archs if they enable it, better to >> limit the option to those archs that supports it. > > Would it be an idea to define ARCH_HAVE_HUGEPAGE in the > arch specific Kconfig file and test against that in > mm/Kconfig ? > I think so, but it would probably be spelled ARCH_HAVE_TRANSPARENT_HUGEPAGE The practice of putting 'depends on X86' in archecture independent Kconfigs should really be discouraged. It has a real feel of hackyness to it. David Daney -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org