[PATCH] mm/mempolicy.c: use enum value MPOL_REBIND_ONCE instead of 0 in mpol_rebind_policy

[PATCH] mm/mempolicy.c: use enum value MPOL_REBIND_ONCE instead of 0 in mpol_rebind_policy

[Wang Sheng-Hui]

We have enum definition in mempolicy.h: MPOL_REBIND_ONCE.
It should replace the magic number 0 for step comparison in
function mpol_rebind_policy.

Signed-off-by: Wang Sheng-Hui <shhuiw@gmail.com>
---
 mm/mempolicy.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/mm/mempolicy.c b/mm/mempolicy.c
index 9c51f9f..ecdaa8d 100644
--- a/mm/mempolicy.c
+++ b/mm/mempolicy.c
@@ -390,7 +390,7 @@ static void mpol_rebind_policy(struct mempolicy *pol, const nodemask_t *newmask,
 {
 	if (!pol)
 		return;
-	if (!mpol_store_user_nodemask(pol) && step == 0 &&
+	if (!mpol_store_user_nodemask(pol) && step == MPOL_REBIND_ONCE &&
 	    nodes_equal(pol->w.cpuset_mems_allowed, *newmask))
 		return;
 
-- 
1.7.1


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [PATCH] mm/mempolicy.c: use enum value MPOL_REBIND_ONCE instead of 0 in mpol_rebind_policy

[David Rientjes]

On Wed, 14 Dec 2011, Wang Sheng-Hui wrote:

> We have enum definition in mempolicy.h: MPOL_REBIND_ONCE.
> It should replace the magic number 0 for step comparison in
> function mpol_rebind_policy.
> 
> Signed-off-by: Wang Sheng-Hui <shhuiw@gmail.com>

Acked-by: David Rientjes <rientjes@google.com>

Tip: when proposing patches, it's helpful to run scripts/get_maintainer.pl 
on your patch file from git to determine who should be cc'd on the email.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [PATCH] mm/mempolicy.c: use enum value MPOL_REBIND_ONCE instead of 0 in mpol_rebind_policy

[Wang Sheng-Hui]

On 2011a1'12ae??15ae?JPY 10:42, David Rientjes wrote:
> On Wed, 14 Dec 2011, Wang Sheng-Hui wrote:
> 
>> We have enum definition in mempolicy.h: MPOL_REBIND_ONCE.
>> It should replace the magic number 0 for step comparison in
>> function mpol_rebind_policy.
>>
>> Signed-off-by: Wang Sheng-Hui <shhuiw@gmail.com>
> 
> Acked-by: David Rientjes <rientjes@google.com>
> 
> Tip: when proposing patches, it's helpful to run scripts/get_maintainer.pl 
> on your patch file from git to determine who should be cc'd on the email.

Thanks for your tip.
I have tried the script with option -f, and only get the mm, kernel mailing
lists, no specific maintainer provided. So here I just posted the patch to 
these 2 lists.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [PATCH] mm/mempolicy.c: use enum value MPOL_REBIND_ONCE instead of 0 in mpol_rebind_policy

[David Rientjes]

On Sat, 17 Dec 2011, Wang Sheng-Hui wrote:

> > Tip: when proposing patches, it's helpful to run scripts/get_maintainer.pl 
> > on your patch file from git to determine who should be cc'd on the email.
> 
> Thanks for your tip.
> I have tried the script with option -f, and only get the mm, kernel mailing
> lists, no specific maintainer provided. So here I just posted the patch to 
> these 2 lists.
> 

$ ./scripts/get_maintainer.pl -f mm/mempolicy.c
Andrew Morton <akpm@linux-foundation.org> (commit_signer:19/23=83%)
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> (commit_signer:8/23=35%)
Stephen Wilson <wilsons@start.ca> (commit_signer:6/23=26%)
Andrea Arcangeli <aarcange@redhat.com> (commit_signer:5/23=22%)
Johannes Weiner <hannes@cmpxchg.org> (commit_signer:3/23=13%)
linux-mm@kvack.org (open list:MEMORY MANAGEMENT)
linux-kernel@vger.kernel.org (open list)

All of those people should be cc'd on patches touching mm/mempolicy.c.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [PATCH] mm/mempolicy.c: use enum value MPOL_REBIND_ONCE instead of 0 in mpol_rebind_policy

[Wang Sheng-Hui]

On 2011a1'12ae??19ae?JPY 06:45, David Rientjes wrote:
> 
> On Sat, 17 Dec 2011, Wang Sheng-Hui wrote:
> 
>>> Tip: when proposing patches, it's helpful to run scripts/get_maintainer.pl 
>>> on your patch file from git to determine who should be cc'd on the email.
>>
>> Thanks for your tip.
>> I have tried the script with option -f, and only get the mm, kernel mailing
>> lists, no specific maintainer provided. So here I just posted the patch to 
>> these 2 lists.
>>
> 
> $ ./scripts/get_maintainer.pl -f mm/mempolicy.c
> Andrew Morton <akpm@linux-foundation.org> (commit_signer:19/23=83%)
> KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> (commit_signer:8/23=35%)
> Stephen Wilson <wilsons@start.ca> (commit_signer:6/23=26%)
> Andrea Arcangeli <aarcange@redhat.com> (commit_signer:5/23=22%)
> Johannes Weiner <hannes@cmpxchg.org> (commit_signer:3/23=13%)
> linux-mm@kvack.org (open list:MEMORY MANAGEMENT)
> linux-kernel@vger.kernel.org (open list)
> 
> All of those people should be cc'd on patches touching mm/mempolicy.c.
Got it. Thanks,

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>