From: Dave Hansen <dave@linux.vnet.ibm.com>
To: KOSAKI Motohiro <kosaki.motohiro@gmail.com>
Cc: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
linux-mm@kvack.org, Andi Kleen <andi@firstfloor.org>,
Wu Fengguang <fengguang.wu@intel.com>,
Andrea Arcangeli <aarcange@redhat.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
linux-kernel@vger.kernel.org
Subject: Re: [RFC][PATCH 2/3] pagemap: export KPF_THP
Date: Mon, 19 Dec 2011 12:57:01 -0800 [thread overview]
Message-ID: <4EEFA51D.2050707@linux.vnet.ibm.com> (raw)
In-Reply-To: <4EEFA278.7010200@gmail.com>
On 12/19/2011 12:45 PM, KOSAKI Motohiro wrote:
> (12/19/11 3:31 PM), Dave Hansen wrote:
>> Let's say you profiled a application and the data shows you're missing
>> the TLB a bunch, but you're also using THP. This might give you a shot
>> at figuring out which parts of your application are *TRULY* THP-backed
>> instead of just the areas you *think* are backed.
>>
>> I'm not sure there's another way to figure it out at the moment.
>
> A snapshot status of THP doesn't help your purpose. I think you need
> perf or similar profiling subsystem enhancement.
>
> Because of, if you've seen KPF_THP at once, It has no guarantee to keep
> hugepages until applications run. Opposite, If you only need rough
> statistics, the best way is to add some new stat to
> /sys/kernel/mm/transparent_hugepage.
But, every single one of the pagemap flags is really just a snapshot
KPF_DIRTY, KPF_LOCKED, etc... The entire interface is inherently a racy
snapshot, and there's not a whole lot you can do about it.
sys_mincore() has the exact same issues. But, that does not make them
useless, nor mean they shouldn't be in the kernel.
A tracepoint or something similar to watch for THP promotions or
demotions would be a great addition to this interface. That way, you at
least have a concept if the data you got has become stale.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-12-19 20:58 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-19 18:38 [RFC][PATCH 0/3] pagemap handles transparent hugepage Naoya Horiguchi
2011-12-19 18:38 ` [RFC][PATCH 1/3] pagemap: avoid splitting thp when reading /proc/pid/pagemap Naoya Horiguchi
2011-12-19 18:45 ` Andi Kleen
2011-12-19 18:48 ` David Rientjes
2011-12-19 19:16 ` Naoya Horiguchi
2011-12-19 18:38 ` [RFC][PATCH 2/3] pagemap: export KPF_THP Naoya Horiguchi
2011-12-19 18:40 ` Andi Kleen
2011-12-19 18:49 ` David Rientjes
2011-12-19 18:55 ` Naoya Horiguchi
2011-12-19 19:05 ` Andrea Arcangeli
2011-12-19 19:24 ` KOSAKI Motohiro
2011-12-19 20:26 ` Naoya Horiguchi
2011-12-19 20:48 ` KOSAKI Motohiro
2011-12-19 21:20 ` Naoya Horiguchi
2011-12-19 20:31 ` Dave Hansen
2011-12-19 20:45 ` KOSAKI Motohiro
2011-12-19 20:57 ` Dave Hansen [this message]
2011-12-19 21:23 ` Andrea Arcangeli
2011-12-20 3:35 ` Wu Fengguang
2011-12-20 18:10 ` Naoya Horiguchi
2011-12-19 18:38 ` [RFC][PATCH 3/3] pagemap: document KPF_THP and show make page-types aware of it Naoya Horiguchi
2011-12-19 18:51 ` David Rientjes
2011-12-20 3:41 ` Wu Fengguang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EEFA51D.2050707@linux.vnet.ibm.com \
--to=dave@linux.vnet.ibm.com \
--cc=aarcange@redhat.com \
--cc=andi@firstfloor.org \
--cc=fengguang.wu@intel.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kosaki.motohiro@gmail.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=n-horiguchi@ah.jp.nec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).