From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx139.postini.com [74.125.245.139]) by kanga.kvack.org (Postfix) with SMTP id D574E6B006E for ; Thu, 29 Dec 2011 00:06:54 -0500 (EST) Received: by qabg40 with SMTP id g40so6521231qab.14 for ; Wed, 28 Dec 2011 21:06:53 -0800 (PST) Message-ID: <4EFBF56B.9050800@gmail.com> Date: Thu, 29 Dec 2011 00:06:51 -0500 From: KOSAKI Motohiro MIME-Version: 1.0 Subject: Re: [PATCH 1/3] mm: test PageSwapBacked in lumpy reclaim References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Hugh Dickins Cc: Andrew Morton , Minchan Kim , linux-mm@kvack.org (12/28/11 11:35 PM), Hugh Dickins wrote: > Lumpy reclaim does well to stop at a PageAnon when there's no swap, but > better is to stop at any PageSwapBacked, which includes shmem/tmpfs too. > > Signed-off-by: Hugh Dickins > --- > mm/vmscan.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- mmotm.orig/mm/vmscan.c 2011-12-28 12:32:02.000000000 -0800 > +++ mmotm/mm/vmscan.c 2011-12-28 16:49:36.463201033 -0800 > @@ -1222,7 +1222,7 @@ static unsigned long isolate_lru_pages(u > * anon page which don't already have a swap slot is > * pointless. > */ > - if (nr_swap_pages<= 0&& PageAnon(cursor_page)&& > + if (nr_swap_pages<= 0&& PageSwapBacked(cursor_page)&& > !PageSwapCache(cursor_page)) > break; It seems obvious. Reviewed-by: KOSAKI Motohiro -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org