From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx115.postini.com [74.125.245.115]) by kanga.kvack.org (Postfix) with SMTP id 487376B004F for ; Wed, 25 Jan 2012 20:27:28 -0500 (EST) Message-ID: <4F20ABDF.8020604@redhat.com> Date: Wed, 25 Jan 2012 20:26:55 -0500 From: Rik van Riel MIME-Version: 1.0 Subject: Re: [PATCH v4 -mm] make swapin readahead skip over holes References: <20120124131351.05309a2a@annuminas.surriel.com> <20120124141400.6d33b7c4@annuminas.surriel.com> <20120125172319.edbbde73.akpm@linux-foundation.org> In-Reply-To: <20120125172319.edbbde73.akpm@linux-foundation.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Minchan Kim , KOSAKI Motohiro , Johannes Weiner , Mel Gorman , Adrian Drzewieki On 01/25/2012 08:23 PM, Andrew Morton wrote: > Just to show that I'm paying attention... > >> --- a/mm/swap_state.c >> +++ b/mm/swap_state.c >> @@ -382,25 +382,23 @@ struct page *read_swap_cache_async(swp_entry_t entry, gfp_t gfp_mask, >> struct page *swapin_readahead(swp_entry_t entry, gfp_t gfp_mask, >> struct vm_area_struct *vma, unsigned long addr) >> { >> - int nr_pages; >> struct page *page; >> - unsigned long offset; >> - unsigned long end_offset; >> + unsigned long offset = swp_offset(entry); >> + unsigned long start_offset, end_offset; >> + unsigned long mask = (1<< page_cluster) - 1; > > This is broken for page_cluster> 31. Fix: I don't know who would want to do their swapins in chunks of 8GB or large at a time, but still a good catch. Want me to send in a v5, or do you prefer to merge a -fix patch in your tree? -- All rights reversed -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org