[PATCH] tracing: adjust shrink_slab beginning trace event name

[PATCH] tracing: adjust shrink_slab beginning trace event name

[Rafael Aquini]

While reviewing vmscan tracing events, I realized all functions which establish paired tracepoints (one at the beginning and another at the end of the function block) were following this naming pattern:
  <tracepoint-name>_begin
  <tarcepoint-name>_end

However, the 'beginning' tracing event for shrink_slab() did not follow the aforementioned naming pattern. This patch renames that trace event to adjust this naming inconsistency.

Signed-off-by: Rafael Aquini <aquini@redhat.com>
---
 include/trace/events/vmscan.h |    2 +-
 mm/vmscan.c                   |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/trace/events/vmscan.h b/include/trace/events/vmscan.h
index edc4b3d..615bd6d 100644
--- a/include/trace/events/vmscan.h
+++ b/include/trace/events/vmscan.h
@@ -179,7 +179,7 @@ DEFINE_EVENT(mm_vmscan_direct_reclaim_end_template, mm_vmscan_memcg_softlimit_re
 	TP_ARGS(nr_reclaimed)
 );
 
-TRACE_EVENT(mm_shrink_slab_start,
+TRACE_EVENT(mm_shrink_slab_begin,
 	TP_PROTO(struct shrinker *shr, struct shrink_control *sc,
 		long nr_objects_to_shrink, unsigned long pgs_scanned,
 		unsigned long lru_pgs, unsigned long cache_items,
diff --git a/mm/vmscan.c b/mm/vmscan.c
index f54a05b..b24a593 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -301,7 +301,7 @@ unsigned long shrink_slab(struct shrink_control *shrink,
 		if (total_scan > max_pass * 2)
 			total_scan = max_pass * 2;
 
-		trace_mm_shrink_slab_start(shrinker, shrink, nr,
+		trace_mm_shrink_slab_begin(shrinker, shrink, nr,
 					nr_pages_scanned, lru_pages,
 					max_pass, delta, total_scan);
 
-- 
1.7.7.4

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [PATCH] tracing: adjust shrink_slab beginning trace event name

[KOSAKI Motohiro]

2011/12/23 Rafael Aquini <aquini@redhat.com>:
> While reviewing vmscan tracing events, I realized all functions which establish paired tracepoints (one at the beginning and another at the end of the function block) were following this naming pattern:
>  <tracepoint-name>_begin
>  <tarcepoint-name>_end
>
> However, the 'beginning' tracing event for shrink_slab() did not follow the aforementioned naming pattern. This patch renames that trace event to adjust this naming inconsistency.
>
> Signed-off-by: Rafael Aquini <aquini@redhat.com>

I don't think it's big issue. but seems no harm change.
 Acked-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>



> ---
>  include/trace/events/vmscan.h |    2 +-
>  mm/vmscan.c                   |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/trace/events/vmscan.h b/include/trace/events/vmscan.h
> index edc4b3d..615bd6d 100644
> --- a/include/trace/events/vmscan.h
> +++ b/include/trace/events/vmscan.h
> @@ -179,7 +179,7 @@ DEFINE_EVENT(mm_vmscan_direct_reclaim_end_template, mm_vmscan_memcg_softlimit_re
>        TP_ARGS(nr_reclaimed)
>  );
>
> -TRACE_EVENT(mm_shrink_slab_start,
> +TRACE_EVENT(mm_shrink_slab_begin,
>        TP_PROTO(struct shrinker *shr, struct shrink_control *sc,
>                long nr_objects_to_shrink, unsigned long pgs_scanned,
>                unsigned long lru_pgs, unsigned long cache_items,
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index f54a05b..b24a593 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -301,7 +301,7 @@ unsigned long shrink_slab(struct shrink_control *shrink,
>                if (total_scan > max_pass * 2)
>                        total_scan = max_pass * 2;
>
> -               trace_mm_shrink_slab_start(shrinker, shrink, nr,
> +               trace_mm_shrink_slab_begin(shrinker, shrink, nr,
>                                        nr_pages_scanned, lru_pages,
>                                        max_pass, delta, total_scan);
>
> --
> 1.7.7.4
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org.  For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [PATCH] tracing: adjust shrink_slab beginning trace event name

[Minchan Kim]

On Fri, Dec 23, 2011 at 11:16 PM, Rafael Aquini <aquini@redhat.com> wrote:
> While reviewing vmscan tracing events, I realized all functions which establish paired tracepoints (one at the beginning and another at the end of the function block) were following this naming pattern:
>  <tracepoint-name>_begin
>  <tarcepoint-name>_end
>
> However, the 'beginning' tracing event for shrink_slab() did not follow the aforementioned naming pattern. This patch renames that trace event to adjust this naming inconsistency.
>
> Signed-off-by: Rafael Aquini <aquini@redhat.com>
Reviewed-by: Minchan Kim <minchan@kernel.org>

-- 
Kind regards,
Minchan Kim

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [resubmit] Re: [PATCH] tracing: adjust shrink_slab beginning trace event name

[Rafael Aquini]

While reviewing vmscan tracing events, I realized all functions which establish paired tracepoints (one at the beginning and another at the end of the function block) were following this naming pattern:
  <tracepoint-name>_begin
  <tarcepoint-name>_end

However, the 'beginning' tracing event for shrink_slab() did not follow the aforementioned naming pattern. This patch renames that trace event to adjust this naming inconsistency.

Signed-off-by: Rafael Aquini <aquini@redhat.com>
Reviewed-by: Minchan Kim <minchan@kernel.org>
Acked-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
---
 include/trace/events/vmscan.h |    2 +-
 mm/vmscan.c                   |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/trace/events/vmscan.h b/include/trace/events/vmscan.h
index f64560e..595a6f0 100644
--- a/include/trace/events/vmscan.h
+++ b/include/trace/events/vmscan.h
@@ -179,7 +179,7 @@ DEFINE_EVENT(mm_vmscan_direct_reclaim_end_template, mm_vmscan_memcg_softlimit_re
        TP_ARGS(nr_reclaimed)
 );
 
-TRACE_EVENT(mm_shrink_slab_start,
+TRACE_EVENT(mm_shrink_slab_begin,
        TP_PROTO(struct shrinker *shr, struct shrink_control *sc,
                long nr_objects_to_shrink, unsigned long pgs_scanned,
                unsigned long lru_pgs, unsigned long cache_items,
diff --git a/mm/vmscan.c b/mm/vmscan.c
index c52b235..84f4fd2 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -325,7 +325,7 @@ unsigned long shrink_slab(struct shrink_control *shrink,
                if (total_scan > max_pass * 2)
                        total_scan = max_pass * 2;
 
-               trace_mm_shrink_slab_start(shrinker, shrink, nr,
+               trace_mm_shrink_slab_begin(shrinker, shrink, nr,
                                        nr_pages_scanned, lru_pages,
                                        max_pass, delta, total_scan);
 
-- 
1.7.7.6

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [resubmit] Re: [PATCH] tracing: adjust shrink_slab beginning trace event name

[Rik van Riel]

On 01/27/2012 07:44 AM, Rafael Aquini wrote:
> While reviewing vmscan tracing events, I realized all functions which establish paired tracepoints (one at the beginning and another at the end of the function block) were following this naming pattern:
>    <tracepoint-name>_begin
>    <tarcepoint-name>_end
>
> However, the 'beginning' tracing event for shrink_slab() did not follow the aforementioned naming pattern. This patch renames that trace event to adjust this naming inconsistency.
>
> Signed-off-by: Rafael Aquini<aquini@redhat.com>
> Reviewed-by: Minchan Kim<minchan@kernel.org>
> Acked-by: KOSAKI Motohiro<kosaki.motohiro@jp.fujitsu.com>

Reviewed-by: Rik van Riel <riel@redhat.com>

-- 
All rights reversed

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>