Re: [PATCH] move vm tools from Documentation/vm/ to tools/

Re: [PATCH] move vm tools from Documentation/vm/ to tools/

[Pekka Enberg]

On Wed, Feb 1, 2012 at 8:34 AM, Dave Young <dyoung@redhat.com> wrote:
> tools/ is the better place for vm tools which are used by many people.
> Moving them to tools also make them open to more users instead of hide in
> Documentation folder.

For moving the code:

Acked-by: Pekka Enberg <penberg@kernel.org>

> Also fixed several coding style problem.

Can you please make that a separate patch?

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [PATCH] move vm tools from Documentation/vm/ to tools/

[Dave Young]

On 02/01/2012 03:32 PM, Pekka Enberg wrote:

> On Wed, Feb 1, 2012 at 8:34 AM, Dave Young <dyoung@redhat.com> wrote:
>> tools/ is the better place for vm tools which are used by many people.
>> Moving them to tools also make them open to more users instead of hide in
>> Documentation folder.
> 
> For moving the code:
> 
> Acked-by: Pekka Enberg <penberg@kernel.org>
> 
>> Also fixed several coding style problem.
> 
> Can you please make that a separate patch?


Will do.

BTW, I think tools/slub/slabinfo.c should be included in tools/vm/ as
well, will move it in v2 patch

> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/



-- 
Thanks
Dave

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [PATCH] move vm tools from Documentation/vm/ to tools/

[Wu Fengguang]

On Wed, Feb 01, 2012 at 03:41:17PM +0800, Dave Young wrote:
> On 02/01/2012 03:32 PM, Pekka Enberg wrote:
> 
> > On Wed, Feb 1, 2012 at 8:34 AM, Dave Young <dyoung@redhat.com> wrote:
> >> tools/ is the better place for vm tools which are used by many people.
> >> Moving them to tools also make them open to more users instead of hide in
> >> Documentation folder.
> > 
> > For moving the code:
> > 
> > Acked-by: Pekka Enberg <penberg@kernel.org>

I have no problem with the move -- actually I sent a similar patch
long time ago to Andrew ;)

Will git-mv end up with a better commit?

> >> Also fixed several coding style problem.
> > 
> > Can you please make that a separate patch?
> 
> 
> Will do.
> 
> BTW, I think tools/slub/slabinfo.c should be included in tools/vm/ as
> well, will move it in v2 patch

CC Christoph. Maybe not a big deal since it's already under tools/.

Thanks,
Fengguang

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [PATCH] move vm tools from Documentation/vm/ to tools/

[Pekka Enberg]

On Wed, Feb 1, 2012 at 10:30 AM, Wu Fengguang <fengguang.wu@intel.com> wrote:
> Will git-mv end up with a better commit?

Just use

    git format-patch -C

to generate the patch and it should be fine.

>> BTW, I think tools/slub/slabinfo.c should be included in tools/vm/ as
>> well, will move it in v2 patch
>
> CC Christoph. Maybe not a big deal since it's already under tools/.

I'm certainly fine with moving it to tools/vm.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [PATCH] move vm tools from Documentation/vm/ to tools/

[Dave Young]

On 02/01/2012 04:30 PM, Wu Fengguang wrote:

> On Wed, Feb 01, 2012 at 03:41:17PM +0800, Dave Young wrote:
>> On 02/01/2012 03:32 PM, Pekka Enberg wrote:
>>
>>> On Wed, Feb 1, 2012 at 8:34 AM, Dave Young <dyoung@redhat.com> wrote:
>>>> tools/ is the better place for vm tools which are used by many people.
>>>> Moving them to tools also make them open to more users instead of hide in
>>>> Documentation folder.
>>>
>>> For moving the code:
>>>
>>> Acked-by: Pekka Enberg <penberg@kernel.org>
> 
> I have no problem with the move -- actually I sent a similar patch
> long time ago to Andrew ;)


Good to know, then do you mind I add your signed-off line?

> 
> Will git-mv end up with a better commit?
> 
>>>> Also fixed several coding style problem.
>>>
>>> Can you please make that a separate patch?
>>
>>
>> Will do.
>>
>> BTW, I think tools/slub/slabinfo.c should be included in tools/vm/ as
>> well, will move it in v2 patch
> 
> CC Christoph. Maybe not a big deal since it's already under tools/.
> 
> Thanks,
> Fengguang
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/



-- 
Thanks
Dave

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [PATCH] move vm tools from Documentation/vm/ to tools/

[Dave Young]

On 02/01/2012 04:44 PM, Pekka Enberg wrote:

> On Wed, Feb 1, 2012 at 10:30 AM, Wu Fengguang <fengguang.wu@intel.com> wrote:
>> Will git-mv end up with a better commit?
> 
> Just use
> 
>     git format-patch -C


good idea, patch looks clean with -C. So there should be no much problem
for review. Also because there's also Makefile changes, I want to still
send as one patch with all changes. How do you think?

> 
> to generate the patch and it should be fine.
> 
>>> BTW, I think tools/slub/slabinfo.c should be included in tools/vm/ as
>>> well, will move it in v2 patch
>>
>> CC Christoph. Maybe not a big deal since it's already under tools/.
> 
> I'm certainly fine with moving it to tools/vm.



-- 
Thanks
Dave

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [PATCH] move vm tools from Documentation/vm/ to tools/

[Christoph Lameter]

On Wed, 1 Feb 2012, Wu Fengguang wrote:

> > BTW, I think tools/slub/slabinfo.c should be included in tools/vm/ as
> > well, will move it in v2 patch
>
> CC Christoph. Maybe not a big deal since it's already under tools/.

Sure. You have my blessing.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>