From: Rik van Riel <riel@redhat.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Mel Gorman <mel@csn.ul.ie>, Minchan Kim <minchan@kernel.org>,
Andrea Arcangeli <aarcange@redhat.com>,
linux-mm@kvack.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] mm: compaction: make compact_control order signed
Date: Wed, 01 Feb 2012 09:59:10 -0500 [thread overview]
Message-ID: <4F29533E.2030704@redhat.com> (raw)
In-Reply-To: <20120201144101.GA5397@elgon.mountain>
On 02/01/2012 09:41 AM, Dan Carpenter wrote:
> "order" is -1 when compacting via /proc/sys/vm/compact_memory. Making
> it unsigned causes a bug in __compact_pgdat() when we test:
>
> if (cc->order< 0 || !compaction_deferred(zone, cc->order))
> compact_zone(zone, cc);
Good catch! I had not even thought to check whether
order was signed in struct compact_control, when I
saw code using -1 as an order in various places :)
> Signed-off-by: Dan Carpenter<dan.carpenter@oracle.com>
Reviewed-by: Rik van Riel <riel@redhat.com>
--
All rights reversed
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-02-01 14:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-01 14:41 [patch] mm: compaction: make compact_control order signed Dan Carpenter
2012-02-01 14:59 ` Rik van Riel [this message]
2012-02-01 20:46 ` Andrew Morton
2012-02-01 21:17 ` Rik van Riel
2012-02-01 21:24 ` Andrew Morton
2012-02-01 21:28 ` Rik van Riel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F29533E.2030704@redhat.com \
--to=riel@redhat.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=minchan@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).