From: Sha Zhengju <handai.szj@gmail.com>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: "Kirill A. Shutemov" <kirill@shutemov.name>,
linux-mm@kvack.org, cgroups@vger.kernel.org,
Sha Zhengju <handai.szj@taobao.com>
Subject: Re: [PATCH] memcg: Free spare array to avoid memory leak
Date: Fri, 09 Mar 2012 11:24:22 +0800 [thread overview]
Message-ID: <4F5977E6.5040205@gmail.com> (raw)
In-Reply-To: <20120309102431.5a8a1c3d.kamezawa.hiroyu@jp.fujitsu.com>
On 03/09/2012 09:24 AM, KAMEZAWA Hiroyuki wrote:
> On Thu, 08 Mar 2012 18:46:13 +0800
> Sha Zhengju<handai.szj@gmail.com> wrote:
>
>> On 03/08/2012 06:35 PM, Kirill A. Shutemov wrote:
>>> On Thu, Mar 08, 2012 at 10:11:32AM +0800, Sha Zhengju wrote:
>>>> On 03/08/2012 07:08 AM, Kirill A. Shutemov wrote:
>>>>> On Tue, Mar 06, 2012 at 08:13:24PM +0800, Sha Zhengju wrote:
>>>>>> From: Sha Zhengju<handai.szj@taobao.com>
>>>>>>
>>>>>> When the last event is unregistered, there is no need to keep the spare
>>>>>> array anymore. So free it to avoid memory leak.
>>>>> It's not a leak. It will be freed on next event register.
>>>> Yeah, I noticed that. But what if it is just the last one and no more
>>>> event registering ?
>>> See my question below. ;)
>>>
>>>>> Yeah, we don't have to keep spare if primary is empty. But is it worth to
>>>>> make code more complicated to save few bytes of memory?
>>>>>
>> If we unregister the last event and *don't* register a new event anymore,
>> the primary is freed but the spare is still kept which has no chance to
>> free.
>>
>> IMHO, it's obvious not a problem of saving bytes but *memory leak*.
>>
> IMHO, it's cached. It will be freed when a memcg is destroyed.
I didn't see that behavior. Could you point it out ? :-)
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-03-09 3:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-06 12:13 [PATCH] memcg: Free spare array to avoid memory leak Sha Zhengju
2012-03-07 23:08 ` Kirill A. Shutemov
2012-03-08 2:11 ` Sha Zhengju
2012-03-08 10:35 ` Kirill A. Shutemov
2012-03-08 10:46 ` Sha Zhengju
2012-03-09 1:24 ` KAMEZAWA Hiroyuki
2012-03-09 3:24 ` Sha Zhengju [this message]
2012-03-09 3:36 ` KAMEZAWA Hiroyuki
2012-03-09 3:40 ` KAMEZAWA Hiroyuki
2012-03-09 4:07 ` Sha Zhengju
2012-03-09 4:20 ` KAMEZAWA Hiroyuki
2012-03-09 9:38 ` Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F5977E6.5040205@gmail.com \
--to=handai.szj@gmail.com \
--cc=cgroups@vger.kernel.org \
--cc=handai.szj@taobao.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kirill@shutemov.name \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).