From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx184.postini.com [74.125.245.184]) by kanga.kvack.org (Postfix) with SMTP id 78A7B6B0092 for ; Mon, 19 Mar 2012 13:58:45 -0400 (EDT) Received: by bkwq16 with SMTP id q16so6356771bkw.14 for ; Mon, 19 Mar 2012 10:58:43 -0700 (PDT) Message-ID: <4F6773CC.2010705@openvz.org> Date: Mon, 19 Mar 2012 21:58:36 +0400 From: Konstantin Khlebnikov MIME-Version: 1.0 Subject: Re: [PATCH] mm: forbid lumpy-reclaim in shrink_active_list() References: <20120319091821.17716.54031.stgit@zurg> <4F676FA4.50905@redhat.com> In-Reply-To: <4F676FA4.50905@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Rik van Riel Cc: "linux-mm@kvack.org" , Andrew Morton , "linux-kernel@vger.kernel.org" , Hugh Dickins , Minchan Kim , Mel Gorman , Johannes Weiner , KAMEZAWA Hiroyuki Rik van Riel wrote: > On 03/19/2012 05:18 AM, Konstantin Khlebnikov wrote: >> This patch reset reclaim mode in shrink_active_list() to RECLAIM_MODE_SINGLE | RECLAIM_MODE_ASYNC. >> (sync/async sign is used only in shrink_page_list and does not affect shrink_active_list) >> >> Currenly shrink_active_list() sometimes works in lumpy-reclaim mode, >> if RECLAIM_MODE_LUMPYRECLAIM left over from earlier shrink_inactive_list(). >> Meanwhile, in age_active_anon() sc->reclaim_mode is totally zero. >> So, current behavior is too complex and confusing, all this looks like bug. >> >> In general, shrink_active_list() populate inactive list for next shrink_inactive_list(). >> Lumpy shring_inactive_list() isolate pages around choosen one from both active and >> inactive lists. So, there no reasons for lumpy-isolation in shrink_active_list() >> >> Proposed-by: Hugh Dickins >> Link: https://lkml.org/lkml/2012/3/15/583 >> Signed-off-by: Konstantin Khlebnikov > > Confirmed, this is already done by commit > 26f5f2f1aea7687565f55c20d69f0f91aa644fb8 in the > linux-next tree. > No, your patch fix this problem only if CONFIG_COMPACTION=y -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org