* [PATCH] mm: avoid CONFIG_MMU=n build failure in pmd_none_or_trans_huge_or_clear_bad
@ 2012-03-21 20:28 Andrea Arcangeli
2012-03-21 20:58 ` Rik van Riel
0 siblings, 1 reply; 2+ messages in thread
From: Andrea Arcangeli @ 2012-03-21 20:28 UTC (permalink / raw)
To: linux-mm
Cc: Andrew Morton, Mel Gorman, Hugh Dickins, Larry Woodman,
Ulrich Obergfell, Rik van Riel, Mark Salter
pmd_none_or_trans_huge_or_clear_bad must be defined after
pmd_trans_huge, so add #ifdef CONFIG_MMU around the whole block that
shall not be needed for archs without pagetables.
Signed-off-by: Andrea Arcangeli <aarcange@redhat.com>
Reported-by: Mark Salter <msalter@redhat.com>
---
include/asm-generic/pgtable.h | 6 +++++-
1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/include/asm-generic/pgtable.h b/include/asm-generic/pgtable.h
index 10f8291..a03c098 100644
--- a/include/asm-generic/pgtable.h
+++ b/include/asm-generic/pgtable.h
@@ -425,6 +425,8 @@ extern void untrack_pfn_vma(struct vm_area_struct *vma, unsigned long pfn,
unsigned long size);
#endif
+#ifdef CONFIG_MMU
+
#ifndef CONFIG_TRANSPARENT_HUGEPAGE
static inline int pmd_trans_huge(pmd_t pmd)
{
@@ -441,7 +443,7 @@ static inline int pmd_write(pmd_t pmd)
return 0;
}
#endif /* __HAVE_ARCH_PMD_WRITE */
-#endif
+#endif /* CONFIG_TRANSPARENT_HUGEPAGE */
/*
* This function is meant to be used by sites walking pagetables with
@@ -500,6 +502,8 @@ static inline int pmd_trans_unstable(pmd_t *pmd)
#endif
}
+#endif /* CONFIG_MMU */
+
#endif /* !__ASSEMBLY__ */
#endif /* _ASM_GENERIC_PGTABLE_H */
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] mm: avoid CONFIG_MMU=n build failure in pmd_none_or_trans_huge_or_clear_bad
2012-03-21 20:28 [PATCH] mm: avoid CONFIG_MMU=n build failure in pmd_none_or_trans_huge_or_clear_bad Andrea Arcangeli
@ 2012-03-21 20:58 ` Rik van Riel
0 siblings, 0 replies; 2+ messages in thread
From: Rik van Riel @ 2012-03-21 20:58 UTC (permalink / raw)
To: Andrea Arcangeli
Cc: linux-mm, Andrew Morton, Mel Gorman, Hugh Dickins, Larry Woodman,
Ulrich Obergfell, Mark Salter
On 03/21/2012 04:28 PM, Andrea Arcangeli wrote:
> pmd_none_or_trans_huge_or_clear_bad must be defined after
> pmd_trans_huge, so add #ifdef CONFIG_MMU around the whole block that
> shall not be needed for archs without pagetables.
>
> Signed-off-by: Andrea Arcangeli<aarcange@redhat.com>
> Reported-by: Mark Salter<msalter@redhat.com>
Acked-by: Rik van Riel <riel@redhat.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-03-21 20:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-21 20:28 [PATCH] mm: avoid CONFIG_MMU=n build failure in pmd_none_or_trans_huge_or_clear_bad Andrea Arcangeli
2012-03-21 20:58 ` Rik van Riel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).