* [PATCH] mm: fix testorder interaction between two kswapd patches
@ 2012-03-23 9:57 Hugh Dickins
2012-03-23 10:24 ` Mel Gorman
2012-03-23 14:37 ` Rik van Riel
0 siblings, 2 replies; 3+ messages in thread
From: Hugh Dickins @ 2012-03-23 9:57 UTC (permalink / raw)
To: Linus Torvalds
Cc: Andrew Morton, Rik van Riel, Mel Gorman, Mel Gorman, linux-mm
Adjusting cc715d99e529 "mm: vmscan: forcibly scan highmem if there are
too many buffer_heads pinning highmem" for -stable reveals that it was
slightly wrong once on top of fe2c2a106663 "vmscan: reclaim at order 0
when compaction is enabled", which specifically adds testorder for the
zone_watermark_ok_safe() test.
Signed-off-by: Hugh Dickins <hughd@google.com>
---
mm/vmscan.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux.git/mm/vmscan.c 2012-03-22 15:03:14.132010081 -0700
+++ linux/mm/vmscan.c 2012-03-23 02:25:04.012090838 -0700
@@ -2817,7 +2817,7 @@ loop_again:
testorder = 0;
if ((buffer_heads_over_limit && is_highmem_idx(i)) ||
- !zone_watermark_ok_safe(zone, order,
+ !zone_watermark_ok_safe(zone, testorder,
high_wmark_pages(zone) + balance_gap,
end_zone, 0)) {
shrink_zone(priority, zone, &sc);
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mm: fix testorder interaction between two kswapd patches
2012-03-23 9:57 [PATCH] mm: fix testorder interaction between two kswapd patches Hugh Dickins
@ 2012-03-23 10:24 ` Mel Gorman
2012-03-23 14:37 ` Rik van Riel
1 sibling, 0 replies; 3+ messages in thread
From: Mel Gorman @ 2012-03-23 10:24 UTC (permalink / raw)
To: Hugh Dickins
Cc: Linus Torvalds, Andrew Morton, Rik van Riel, Mel Gorman, linux-mm
On Fri, Mar 23, 2012 at 02:57:31AM -0700, Hugh Dickins wrote:
> Adjusting cc715d99e529 "mm: vmscan: forcibly scan highmem if there are
> too many buffer_heads pinning highmem" for -stable reveals that it was
> slightly wrong once on top of fe2c2a106663 "vmscan: reclaim at order 0
> when compaction is enabled", which specifically adds testorder for the
> zone_watermark_ok_safe() test.
>
> Signed-off-by: Hugh Dickins <hughd@google.com>
Acked-by: Mel Gorman <mel@csn.ul.ie>
--
Mel Gorman
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mm: fix testorder interaction between two kswapd patches
2012-03-23 9:57 [PATCH] mm: fix testorder interaction between two kswapd patches Hugh Dickins
2012-03-23 10:24 ` Mel Gorman
@ 2012-03-23 14:37 ` Rik van Riel
1 sibling, 0 replies; 3+ messages in thread
From: Rik van Riel @ 2012-03-23 14:37 UTC (permalink / raw)
To: Hugh Dickins
Cc: Linus Torvalds, Andrew Morton, Mel Gorman, Mel Gorman, linux-mm
On 03/23/2012 05:57 AM, Hugh Dickins wrote:
> Adjusting cc715d99e529 "mm: vmscan: forcibly scan highmem if there are
> too many buffer_heads pinning highmem" for -stable reveals that it was
> slightly wrong once on top of fe2c2a106663 "vmscan: reclaim at order 0
> when compaction is enabled", which specifically adds testorder for the
> zone_watermark_ok_safe() test.
>
> Signed-off-by: Hugh Dickins<hughd@google.com>
Acked-by: Rik van Riel <riel@redhat.com>
--
All rights reversed
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-03-23 14:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-23 9:57 [PATCH] mm: fix testorder interaction between two kswapd patches Hugh Dickins
2012-03-23 10:24 ` Mel Gorman
2012-03-23 14:37 ` Rik van Riel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).