From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx152.postini.com [74.125.245.152]) by kanga.kvack.org (Postfix) with SMTP id A6A606B004D for ; Mon, 26 Mar 2012 12:05:38 -0400 (EDT) Received: by bkwq16 with SMTP id q16so5754943bkw.14 for ; Mon, 26 Mar 2012 09:05:36 -0700 (PDT) Message-ID: <4F7093CD.4060008@openvz.org> Date: Mon, 26 Mar 2012 20:05:33 +0400 From: Konstantin Khlebnikov MIME-Version: 1.0 Subject: Re: [PATCH v6 6/7] mm/memcg: kill mem_cgroup_lru_del() References: <20120322214944.27814.42039.stgit@zurg> <20120322215639.27814.4996.stgit@zurg> <20120326152315.GC22754@tiehlicka.suse.cz> In-Reply-To: <20120326152315.GC22754@tiehlicka.suse.cz> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Michal Hocko Cc: "linux-mm@kvack.org" , Andrew Morton , "linux-kernel@vger.kernel.org" , Hugh Dickins , KAMEZAWA Hiroyuki Michal Hocko wrote: > On Fri 23-03-12 01:56:39, Konstantin Khlebnikov wrote: >> This patch kills mem_cgroup_lru_del(), we can use mem_cgroup_lru_del_list() >> instead. On 0-order isolation we already have right lru list id. >> >> Signed-off-by: Konstantin Khlebnikov >> Cc: KAMEZAWA Hiroyuki >> Cc: Hugh Dickins > > Yes, looks good > Acked-by: Michal Hocko > > Just a small nit.. > [...] >> diff --git a/mm/vmscan.c b/mm/vmscan.c >> index 5f6ed98..9de66be 100644 >> --- a/mm/vmscan.c >> +++ b/mm/vmscan.c > [...] >> @@ -1205,8 +1205,11 @@ static unsigned long isolate_lru_pages(unsigned long nr_to_scan, >> >> if (__isolate_lru_page(cursor_page, mode) == 0) { >> unsigned int isolated_pages; >> + enum lru_list cursor_lru; >> >> - mem_cgroup_lru_del(cursor_page); >> + cursor_lru = page_lru(cursor_page); >> + mem_cgroup_lru_del_list(cursor_page, >> + cursor_lru); > > Why not mem_cgroup_lru_del_list(cursor_page, > page_lru(cursor_page)); > The patch would be smaller and it doesn't make checkpatch unhappy as well. Lumpy-reclaim supposed to be removed soon, so... > >> list_move(&cursor_page->lru, dst); >> isolated_pages = hpage_nr_pages(cursor_page); >> nr_taken += isolated_pages; >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> Please read the FAQ at http://www.tux.org/lkml/ > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org