From: Seth Jennings <sjenning@linux.vnet.ibm.com>
To: Dan Magenheimer <dan.magenheimer@oracle.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Nitin Gupta <ngupta@vflare.org>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Robert Jennings <rcj@linux.vnet.ibm.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH] staging: zsmalloc: fix memory leak
Date: Wed, 04 Apr 2012 11:26:14 -0500 [thread overview]
Message-ID: <4F7C7626.40506@linux.vnet.ibm.com> (raw)
In-Reply-To: <d858d87f-6e07-4303-a9b3-e41ff93c8080@default>
On 04/04/2012 11:03 AM, Dan Magenheimer wrote:
>> From: Seth Jennings [mailto:sjenning@linux.vnet.ibm.com]
>> Sent: Monday, April 02, 2012 8:14 AM
>> To: Greg Kroah-Hartman
>> Cc: Nitin Gupta; Dan Magenheimer; Konrad Rzeszutek Wilk; Robert Jennings; Seth Jennings;
>> devel@driverdev.osuosl.org; linux-kernel@vger.kernel.org; linux-mm@kvack.org
>> Subject: [PATCH] staging: zsmalloc: fix memory leak
>>
>> From: Nitin Gupta <ngupta@vflare.org>
>>
>> This patch fixes a memory leak in zsmalloc where the first
>> subpage of each zspage is leaked when the zspage is freed.
>>
>> Based on 3.4-rc1.
>>
>> Signed-off-by: Nitin Gupta <ngupta@vflare.org>
>> Acked-by: Seth Jennings <sjenning@linux.vnet.ibm.com>
>
> This is a rather severe memory leak and will affect most
> benchmarking anyone does to evaluate zcache in 3.4 (e.g. as
> to whether zcache is suitable for promotion), so t'would be nice
> to get this patch in for -rc2. (Note it fixes a "regression"
> since it affects zcache only in 3.4+ because the fix is to
> the new zsmalloc allocator... so no change to stable trees.)
>
> Acked-by: Dan Magenheimer <dan.magenheimer@oracle.com>
Thanks Dan for this clarification and the Ack.
I should have tagged this as urgent for the 3.4 release
and no impact on stable trees, since 3.4 is the first release
with this code.
--
Seth
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-04-04 16:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <<1333376036-9841-1-git-send-email-sjenning@linux.vnet.ibm.com>
2012-04-04 16:03 ` [PATCH] staging: zsmalloc: fix memory leak Dan Magenheimer
2012-04-04 16:26 ` Seth Jennings [this message]
2012-04-09 20:23 ` Seth Jennings
2012-04-09 21:43 ` Greg Kroah-Hartman
2012-04-09 22:06 ` Seth Jennings
2012-04-02 14:13 Seth Jennings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F7C7626.40506@linux.vnet.ibm.com \
--to=sjenning@linux.vnet.ibm.com \
--cc=dan.magenheimer@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ngupta@vflare.org \
--cc=rcj@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).