From: Rik van Riel <riel@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Konstantin Khlebnikov <khlebnikov@openvz.org>,
Hugh Dickins <hughd@google.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: fix page-faults detection in swap-token logic
Date: Fri, 06 Apr 2012 17:14:41 -0400 [thread overview]
Message-ID: <4F7F5CC1.3080107@redhat.com> (raw)
In-Reply-To: <20110829160637.bfc86e63.akpm@linux-foundation.org>
On 08/29/2011 07:06 PM, Andrew Morton wrote:
> On Sat, 27 Aug 2011 12:32:01 +0300
> Konstantin Khlebnikov<khlebnikov@openvz.org> wrote:
>
>> After commit v2.6.36-5896-gd065bd8 "mm: retry page fault when blocking on disk transfer"
>> we usually wait in page-faults without mmap_sem held, so all swap-token logic was broken,
>> because it based on using rwsem_is_locked(&mm->mmap_sem) as sign of in progress page-faults.
>
> If I'm interpreting this correctly, the thrash-handling logic has been
> effectively disabled for a year and nobody noticed.
>
>> This patch adds to mm_struct atomic counter of in progress page-faults for mm with swap-token.
>
> We desperately need to delete some code from mm/. This seems like a
> great candidate. Someone prove me wrong?
You are absolutely right. The swap token code broke without
anyone noticing, and there is no good way to integrate it with
cgroups naturalization...
I'll send a patch to remove the swap token code.
--
All rights reversed
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2012-04-06 21:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-27 9:32 [PATCH] mm: fix page-faults detection in swap-token logic Konstantin Khlebnikov
2011-08-29 23:06 ` Andrew Morton
2012-04-06 21:14 ` Rik van Riel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F7F5CC1.3080107@redhat.com \
--to=riel@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=khlebnikov@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).