From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx164.postini.com [74.125.245.164]) by kanga.kvack.org (Postfix) with SMTP id 2A6F96B00E8 for ; Wed, 25 Apr 2012 14:05:33 -0400 (EDT) Message-ID: <4F983CF1.2060800@redhat.com> Date: Wed, 25 Apr 2012 14:05:37 -0400 From: Rik van Riel MIME-Version: 1.0 Subject: Re: [PATCH] rename is_mlocked_vma() to mlocked_vma_newpage() References: <1335375955-32037-1-git-send-email-yinghan@google.com> In-Reply-To: <1335375955-32037-1-git-send-email-yinghan@google.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Ying Han Cc: KAMEZAWA Hiroyuki , Andrew Morton , linux-mm@kvack.org On 04/25/2012 01:45 PM, Ying Han wrote: > Andrew pointed out that the is_mlocked_vma() is misnamed. A function > with name like that would expect bool return and no side-effects. > > Since it is called on the fault path for new page, rename it in this > patch. > > Signed-off-by: Ying Han Reviewed-by: Rik van Riel -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org