From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx154.postini.com [74.125.245.154]) by kanga.kvack.org (Postfix) with SMTP id 4C39F6B0044 for ; Wed, 25 Apr 2012 18:29:32 -0400 (EDT) Message-ID: <4F987ACB.8050604@linux.intel.com> Date: Wed, 25 Apr 2012 15:29:31 -0700 From: "H. Peter Anvin" MIME-Version: 1.0 Subject: Re: [BUG]memblock: fix overflow of array index References: <20120425222819.GF8989@google.com> In-Reply-To: <20120425222819.GF8989@google.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Tejun Heo Cc: Peter Teoh , linux-kernel@vger.kernel.org, Andrew Morton , Ingo Molnar , linux-mm@kvack.org On 04/25/2012 03:28 PM, Tejun Heo wrote: > > All indexes in memblock are integers. Changing that particular one to > unsigned int doesn't fix anything. I think it just makes things more > confusing. If there ever are cases w/ more then 2G memblocks, we're > going for 64bit not unsigned. > I would expect there to be plenty of memblocks larger than 2G? -hpa -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org