From: Glauber Costa <glommer@parallels.com>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"cgroups@vger.kernel.org" <cgroups@vger.kernel.org>,
Michal Hocko <mhocko@suse.cz>,
Johannes Weiner <hannes@cmpxchg.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Tejun Heo <tj@kernel.org>, Han Ying <yinghan@google.com>,
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>,
kamezawa.hiroyuki@gmail.com
Subject: Re: [RFC][PATCH 3/7 v2] res_counter: add res_counter_uncharge_until()
Date: Fri, 27 Apr 2012 14:08:28 -0300 [thread overview]
Message-ID: <4F9AD28C.60508@parallels.com> (raw)
In-Reply-To: <4F9A343F.7020409@jp.fujitsu.com>
On 04/27/2012 02:53 AM, KAMEZAWA Hiroyuki wrote:
> From bb0168d5c85f62f36434956e4728a67d0cc41e55 Mon Sep 17 00:00:00 2001
> From: KAMEZAWA Hiroyuki<kamezawa.hiroyu@jp.fujitsu.com>
> Date: Thu, 26 Apr 2012 18:48:07 +0900
> Subject: [PATCH 3/9] memcg: add res_counter_uncharge_until()
>
> At killing res_counter which is a child of other counter,
> we need to do
> res_counter_uncharge(child, xxx)
> res_counter_charge(parent, xxx)
>
> This is not atomic and wasting cpu. This patch adds
> res_counter_uncharge_until(). This function's uncharge propagates
> to ancestors until specified res_counter.
>
> res_counter_uncharge_until(child, parent, xxx)
>
> This ops is atomic and more efficient.
>
> Originaly-written-by: Frederic Weisbecker<fweisbec@gmail.com>
> Signed-off-by: KAMEZAWA Hiroyuki<kamezawa.hiroyu@jp.fujitsu.com>
I have been carrying Frederic's patch itself in my code for a while now.
Why not just use it? What are you doing differently to justify writing a
patch yourself? It's a bit of credit giving as well
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-04-27 17:10 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-27 5:45 [RFC][PATCH 0/7 v2] memcg: prevent failure in pre_destroy() KAMEZAWA Hiroyuki
2012-04-27 5:49 ` [RFC][PATCH 1/7 v2] temporal compile-fix in linux-next KAMEZAWA Hiroyuki
2012-04-30 8:47 ` Aneesh Kumar K.V
2012-04-27 5:51 ` [RFC][PATCH 2/7 v2] memcg: fix error code in hugetlb_force_memcg_empty() KAMEZAWA Hiroyuki
2012-04-30 8:49 ` Aneesh Kumar K.V
2012-04-27 5:53 ` [RFC][PATCH 3/7 v2] res_counter: add res_counter_uncharge_until() KAMEZAWA Hiroyuki
2012-04-27 17:08 ` Glauber Costa [this message]
2012-04-27 23:51 ` Hiroyuki Kamezawa
2012-04-27 18:18 ` Tejun Heo
2012-04-27 23:51 ` Hiroyuki Kamezawa
2012-04-27 5:54 ` [RFC][PATCH 4/7 v2] memcg: use res_counter_uncharge_until in move_parent KAMEZAWA Hiroyuki
2012-04-27 17:16 ` Glauber Costa
2012-04-27 18:26 ` Ying Han
2012-04-27 20:11 ` Glauber Costa
2012-04-27 23:58 ` Hiroyuki Kamezawa
2012-04-27 18:20 ` Tejun Heo
2012-04-27 23:59 ` Hiroyuki Kamezawa
2012-04-30 9:00 ` Aneesh Kumar K.V
2012-04-27 5:58 ` [RFC][PATCH 5/9 v2] move charges to root at rmdir if use_hierarchy is unset KAMEZAWA Hiroyuki
2012-04-27 19:12 ` Ying Han
2012-04-28 0:01 ` Hiroyuki Kamezawa
2012-04-30 9:07 ` Aneesh Kumar K.V
2012-04-27 6:00 ` [RFC][PATCH 6/9 v2] memcg: don't uncharge in mem_cgroup_move_account KAMEZAWA Hiroyuki
2012-04-27 6:02 ` [RFC][PATCH 7/9 v2] cgroup: avoid attaching task to a cgroup under rmdir() KAMEZAWA Hiroyuki
2012-04-27 10:39 ` Frederic Weisbecker
2012-04-28 0:06 ` Hiroyuki Kamezawa
2012-04-27 20:31 ` Tejun Heo
2012-04-27 20:33 ` Tejun Heo
2012-04-27 6:04 ` [RFC][PATCH 8/9 v2] cgroup: avoid creating new cgroup under a cgroup being destroyed KAMEZAWA Hiroyuki
2012-04-27 17:18 ` Glauber Costa
2012-04-27 20:40 ` Tejun Heo
2012-04-27 20:41 ` Tejun Heo
2012-04-28 0:20 ` Hiroyuki Kamezawa
2012-04-28 2:00 ` Tejun Heo
2012-04-28 9:31 ` Hiroyuki Kamezawa
2012-04-28 21:31 ` Tejun Heo
2012-04-27 6:06 ` [RFC][PATCH 9/9 v2] memcg: never return error at pre_destroy() KAMEZAWA Hiroyuki
2012-04-27 21:28 ` Ying Han
2012-04-28 0:25 ` Hiroyuki Kamezawa
2012-04-30 17:02 ` Ying Han
2012-05-01 22:28 ` Suleiman Souhlal
2012-05-02 3:34 ` Hiroyuki Kamezawa
2012-04-27 18:16 ` [RFC][PATCH 0/7 v2] memcg: prevent failure in pre_destroy() Tejun Heo
2012-04-27 23:48 ` Hiroyuki Kamezawa
2012-04-28 16:13 ` Michal Hocko
2012-04-29 6:03 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F9AD28C.60508@parallels.com \
--to=glommer@parallels.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=cgroups@vger.kernel.org \
--cc=fweisbec@gmail.com \
--cc=hannes@cmpxchg.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kamezawa.hiroyuki@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=tj@kernel.org \
--cc=yinghan@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).