From: Minchan Kim <minchan@kernel.org>
To: Pekka Enberg <penberg@kernel.org>,
linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>
Subject: vmevent: question?
Date: Mon, 30 Apr 2012 16:06:25 +0900 [thread overview]
Message-ID: <4F9E39F1.5030600@kernel.org> (raw)
Hi Pekka,
I looked into vmevent and have few questions.
vmevent_smaple gathers all registered values to report to user if vmevent match.
But the time gap between vmevent match check and vmevent_sample_attr could make error
so user could confuse.
Q 1. Why do we report _all_ registered vmstat value?
In my opinion, it's okay just to report _a_ value vmevent_match happens.
Q 2. Is it okay although value when vmevent_match check happens is different with
vmevent_sample_attr in vmevent_sample's for loop?
I think it's not good.
Q 3. Do you have any plan to change getting value's method?
Now it's IRQ context so we have limitation to get a vmstat values so that
It couldn't be generic. IMHO, To merge into mainline, we should solve this problem.
Q 4. Do you have any plan for this patchset to merge into mainline?
Thanks.
--
Kind regards,
Minchan Kim
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next reply other threads:[~2012-04-30 7:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-30 7:06 Minchan Kim [this message]
2012-04-30 7:35 ` vmevent: question? Pekka Enberg
2012-04-30 7:52 ` Minchan Kim
2012-04-30 8:01 ` Pekka Enberg
2012-04-30 8:36 ` Minchan Kim
2012-05-03 7:24 ` Pekka Enberg
2012-05-03 7:57 ` Minchan Kim
2012-05-03 8:07 ` Pekka Enberg
2012-05-03 8:13 ` Minchan Kim
2012-04-30 7:54 ` Anton Vorontsov
2012-04-30 8:03 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F9E39F1.5030600@kernel.org \
--to=minchan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).