From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx175.postini.com [74.125.245.175]) by kanga.kvack.org (Postfix) with SMTP id 71FF56B00E9 for ; Tue, 8 May 2012 20:58:15 -0400 (EDT) Message-ID: <4FA9C127.5020908@kernel.org> Date: Wed, 09 May 2012 09:58:15 +0900 From: Minchan Kim MIME-Version: 1.0 Subject: Re: [PATCH 4/4] zsmalloc: zsmalloc: align cache line size References: <1336027242-372-1-git-send-email-minchan@kernel.org> <1336027242-372-4-git-send-email-minchan@kernel.org> <4FA28EFD.5070002@vflare.org> <4FA33E89.6080206@kernel.org> <4FA7C2BC.2090400@vflare.org> <4FA87837.3050208@kernel.org> <731b6638-8c8c-4381-a00f-4ecd5a0e91ae@default> In-Reply-To: <731b6638-8c8c-4381-a00f-4ecd5a0e91ae@default> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Dan Magenheimer Cc: Nitin Gupta , Pekka Enberg , Greg Kroah-Hartman , Seth Jennings , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, cl@linux-foundation.org On 05/08/2012 11:00 PM, Dan Magenheimer wrote: >> From: Minchan Kim [mailto:minchan@kernel.org] >>> zcache can potentially create a lot of pools, so the latter will save >>> some memory. >> >> >> Dumb question. >> Why should we create pool per user? >> What's the problem if there is only one pool in system? > > zcache doesn't use zsmalloc for cleancache pages today, but > that's Seth's plan for the future. Then if there is a > separate pool for each cleancache pool, when a filesystem > is umount'ed, it isn't necessary to walk through and delete > all pages one-by-one, which could take quite awhile. > > ramster needs one pool for each client (i.e. machine in the > cluster) for frontswap pages for the same reason, and > later, for cleancache pages, one per mounted filesystem > per client Fair enough. But some subsystems can't want a own pool for not waste unnecessary memory. Then, how about this interfaces like slab? 1. zs_handle zs_malloc(size_t size, gfp_t flags) - share a pool by many subsystem(like kmalloc) 2. zs_handle zs_malloc_pool(struct zs_pool *pool, size_t size) - use own pool(like kmem_cache_alloc) Any thoughts? > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@kvack.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ > Don't email: email@kvack.org > -- Kind regards, Minchan Kim -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org