From: Minchan Kim <minchan@kernel.org>
To: Dan Magenheimer <dan.magenheimer@oracle.com>
Cc: linux-mm@kvack.org
Subject: Re: is there a "lru_cache_add_anon_tail"?
Date: Fri, 11 May 2012 09:34:41 +0900 [thread overview]
Message-ID: <4FAC5EA1.5040201@kernel.org> (raw)
In-Reply-To: <66ea94b0-2e40-44d1-9621-05f2a8257298@default>
On 05/11/2012 01:13 AM, Dan Magenheimer wrote:
> (Still working on allowing zcache to "evict" swap pages...)
>
> Apologies if I got head/tail reversed as used by the
> lru queues... the "directional sense" of the queues is
> not obvious so I'll describe using different terminology...
>
> If I have an anon page and I would like to add it to
> the "reclaim soonest" end of the queue instead of the
> "most recently used so don't reclaim it for a long time"
> end of the queue, does an equivalent function similar to
> lru_cache_add_anon(page) exist?
Nope.
>
> In other words, I want this dirty anon page to be
> swapped out ASAP.
Why do you want to do that at the cost of ignoring of LRU ordering?
>
> If no such function exists, can anyone more familiar
> with the VM LRU queues suggest the code for
> this function "lru_cache_add_anon_XXX(page)?
> Also what would be the proper text for XXX?
tail
>
> I have some (experimental) code now to use it so
> could iterate/debug with any suggested code. The
> calling snippet is:
>
> __set_page_locked(new_page);
> SetPageSwapBacked(new_page);
> ret = __add_to_swap_cache(new_page, entry);
> if (likely(!ret)) {
> radix_tree_preload_end();
> lru_cache_add_anon_XXX(new_page)
> if (frontswap_get_page(new_page) = 0)
> SetPageUptodate(new_page);
> unlock_page(new_page);
>
> This works using a call to the existing lru_cache_add_anon
> but new_page doesn't get swapped out for a long time.
Yes. it's to add the page to "most recently used so don't reclaim it for a long time" in your terms.
Adding new lru_cache_add_anon_tail isn't difficult but we need justification why we should do.
>
> Thanks for any help/suggestions!
> Dan
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org. For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
> Don't email: <a href=ilto:"dont@kvack.org"> email@kvack.org </a>
>
qqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqq
--
Kind regards,
Minchan Kim
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2012-05-11 0:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-10 16:13 is there a "lru_cache_add_anon_tail"? Dan Magenheimer
2012-05-10 17:32 ` KOSAKI Motohiro
2012-05-11 16:21 ` Dan Magenheimer
2012-05-11 0:34 ` Minchan Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FAC5EA1.5040201@kernel.org \
--to=minchan@kernel.org \
--cc=dan.magenheimer@oracle.com \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).