From: Minchan Kim <minchan@kernel.org>
To: Seth Jennings <sjenning@linux.vnet.ibm.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Nitin Gupta <ngupta@vflare.org>,
Dan Magenheimer <dan.magenheimer@oracle.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 2/3] zram: remove comment in Kconfig
Date: Tue, 15 May 2012 11:31:24 +0900 [thread overview]
Message-ID: <4FB1BFFC.8080405@kernel.org> (raw)
In-Reply-To: <4FB119CA.2080606@linux.vnet.ibm.com>
On 05/14/2012 11:42 PM, Seth Jennings wrote:
> On 05/14/2012 03:45 AM, Minchan Kim wrote:
>
>> Exactly speaking, zram should has dependency with
>> zsmalloc, not x86. So x86 dependeny check is redundant.
>>
>> Signed-off-by: Minchan Kim <minchan@kernel.org>
>> ---
>> drivers/staging/zram/Kconfig | 4 +---
>> 1 file changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/drivers/staging/zram/Kconfig b/drivers/staging/zram/Kconfig
>> index 9d11a4c..ee23a86 100644
>> --- a/drivers/staging/zram/Kconfig
>> +++ b/drivers/staging/zram/Kconfig
>> @@ -1,8 +1,6 @@
>> config ZRAM
>> tristate "Compressed RAM block device support"
>> - # X86 dependency is because zsmalloc uses non-portable pte/tlb
>> - # functions
>> - depends on BLOCK && SYSFS && X86
>> + depends on BLOCK && SYSFS
>
>
> Two comments here:
>
> 1) zram should really depend on ZSMALLOC instead of selecting it
> because, as the patch has it, zram could be selected on an arch that
> zsmalloc doesn't support.
Argh, Totally my mistake. my patch didn't match with my comment, either. :(
>
> 2) This change would need to be done in zcache as well.
I see.
Seth, Thanks.
send v2.
== CUT_HERE ==
next prev parent reply other threads:[~2012-05-15 2:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-14 8:45 [PATCH 1/3] zsmalloc: support zsmalloc to ARM, MIPS, SUPERH Minchan Kim
2012-05-14 8:45 ` [PATCH 2/3] zram: remove comment in Kconfig Minchan Kim
2012-05-14 14:42 ` Seth Jennings
2012-05-15 2:31 ` Minchan Kim [this message]
2012-05-15 14:37 ` Konrad Rzeszutek Wilk
2012-05-15 15:55 ` Greg Kroah-Hartman
2012-05-14 8:45 ` [PATCH 3/3] x86: Support local_flush_tlb_kernel_range Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FB1BFFC.8080405@kernel.org \
--to=minchan@kernel.org \
--cc=dan.magenheimer@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ngupta@vflare.org \
--cc=sjenning@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).