From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx104.postini.com [74.125.245.104]) by kanga.kvack.org (Postfix) with SMTP id F0E8D6B004D for ; Tue, 15 May 2012 05:44:50 -0400 (EDT) Received: by dakp5 with SMTP id p5so10397719dak.14 for ; Tue, 15 May 2012 02:44:50 -0700 (PDT) Message-ID: <4FB22589.9050406@gmail.com> Date: Tue, 15 May 2012 17:44:41 +0800 From: Cong Wang MIME-Version: 1.0 Subject: Re: [PATCH 1/10] shmem: replace page if mapping excludes its zone References: <4FB0C888.8070805@gmail.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Hugh Dickins Cc: Andrew Morton , Christoph Hellwig , KAMEZAWA Hiroyuki , Alan Cox , Stephane Marchesin , Andi Kleen , Dave Airlie , Daniel Vetter , Rob Clark , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org On 05/15/2012 03:42 AM, Hugh Dickins wrote: > I'm not going to rush the incremental patch to fix this: need to think > about it quietly first. > > If you're wondering what I'm talking about (sorry, I don't have time > to explain more right now), take a look at comment and git history of > line 2956 (in 3.4-rc7) of mm/memory.c: > if (unlikely(!PageSwapCache(page) || page_private(page) != entry.val)) > I don't suppose anyone ever actually hit the bug in the years before > we added that protection, but we still ought to guard against it, > there and here in shmem_replace_page(). > Ok, I have no objections. Thanks for your patches anyway! -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org