From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx193.postini.com [74.125.245.193]) by kanga.kvack.org (Postfix) with SMTP id 748066B0082 for ; Thu, 17 May 2012 04:05:33 -0400 (EDT) Message-ID: <4FB4B177.9020804@kernel.org> Date: Thu, 17 May 2012 17:06:15 +0900 From: Minchan Kim MIME-Version: 1.0 Subject: Re: [PATCH v2 2/3] remove dependency with x86 References: <1337133919-4182-1-git-send-email-minchan@kernel.org> <1337133919-4182-2-git-send-email-minchan@kernel.org> <4FB3DFDB.80605@linux.vnet.ibm.com> In-Reply-To: <4FB3DFDB.80605@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Seth Jennings Cc: Greg Kroah-Hartman , Nitin Gupta , Dan Magenheimer , linux-kernel@vger.kernel.org, linux-mm@kvack.org On 05/17/2012 02:11 AM, Seth Jennings wrote: > On 05/15/2012 09:05 PM, Minchan Kim wrote: > >> Exactly saying, [zram|zcache] should has a dependency with >> zsmalloc, not x86. So replace x86 dependeny with ZSMALLOC. >> >> Reviewed-by: Konrad Rzeszutek Wilk >> Signed-off-by: Minchan Kim >> --- >> drivers/staging/zcache/Kconfig | 3 +-- >> drivers/staging/zram/Kconfig | 3 +-- >> 2 files changed, 2 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/staging/zcache/Kconfig b/drivers/staging/zcache/Kconfig >> index 7048e01..ceb7f28 100644 >> --- a/drivers/staging/zcache/Kconfig >> +++ b/drivers/staging/zcache/Kconfig >> @@ -2,8 +2,7 @@ config ZCACHE >> bool "Dynamic compression of swap pages and clean pagecache pages" >> # X86 dependency is because zsmalloc uses non-portable pte/tlb >> # functions >> - depends on (CLEANCACHE || FRONTSWAP) && CRYPTO=y && X86 >> - select ZSMALLOC >> + depends on (CLEANCACHE || FRONTSWAP) && CRYPTO=y && ZSMALLOC > > > Sorry Minchan, I should have said this the first time around. I ran > into this issue before with CRYTPO vs CRYPTO=y. ZCACHE is a bool where > ZSMALLOC is a tristate. It is not sufficient for ZSMALLOC to be set; it > _must_ be builtin, otherwise you get linker errors. > > The dependency should be ZSMALLOC=y. Sigh. I should have been more careful. Thanks. I will fix it in next spin. > > Thanks, > Seth > -- Kind regards, Minchan Kim -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org