linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: KOSAKI Motohiro <kosaki.motohiro@gmail.com>
To: Hugh Dickins <hughd@google.com>
Cc: Dave Jones <davej@redhat.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Cong Wang <amwang@redhat.com>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	kosaki.motohiro@gmail.com
Subject: Re: WARNING: at mm/page-writeback.c:1990 __set_page_dirty_nobuffers+0x13a/0x170()
Date: Fri, 01 Jun 2012 04:51:37 -0400	[thread overview]
Message-ID: <4FC88299.1040707@gmail.com> (raw)
In-Reply-To: <alpine.LSU.2.00.1206010030050.8462@eggly.anvils>

>   	mlock_migrate_page(newpage, page);
> --- 3.4.0+/mm/page-writeback.c	2012-05-29 08:09:58.304806782 -0700
> +++ linux/mm/page-writeback.c	2012-06-01 00:23:43.984116973 -0700
> @@ -1987,7 +1987,10 @@ int __set_page_dirty_nobuffers(struct pa
>   		mapping2 = page_mapping(page);
>   		if (mapping2) { /* Race with truncate? */
>   			BUG_ON(mapping2 != mapping);
> -			WARN_ON_ONCE(!PagePrivate(page)&&  !PageUptodate(page));
> +			if (WARN_ON(!PagePrivate(page)&&  !PageUptodate(page)))
> +				print_symbol(KERN_WARNING
> +				    "mapping->a_ops->writepage: %s\n",
> +				    (unsigned long)mapping->a_ops->writepage);

type mismatch? I guess you want %pf or %pF.


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2012-06-01  8:51 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-30 16:33 WARNING: at mm/page-writeback.c:1990 __set_page_dirty_nobuffers+0x13a/0x170() Dave Jones
2012-05-31  0:57 ` Dave Jones
2012-06-01  2:31   ` Dave Jones
2012-06-01  2:43     ` Linus Torvalds
2012-06-01 13:43       ` Dave Jones
2012-06-01  8:44     ` Hugh Dickins
2012-06-01  8:51       ` KOSAKI Motohiro [this message]
2012-06-01  9:08         ` Hugh Dickins
2012-06-01  9:12           ` KOSAKI Motohiro
2012-06-01 14:09       ` Dave Jones
2012-06-01 14:14       ` Dave Jones
2012-06-01 16:12       ` Dave Jones
2012-06-01 17:16         ` Dave Jones
2012-06-01 22:17           ` Hugh Dickins
2012-06-02  1:45             ` Linus Torvalds
2012-06-02  4:40               ` Hugh Dickins
2012-06-02  4:58                 ` Linus Torvalds
2012-06-02  7:20                   ` Hugh Dickins
2012-06-02  7:17                 ` Markus Trippelsdorf
2012-06-02  7:22                   ` Hugh Dickins
2012-06-02  7:27                     ` [PATCH] mm: fix warning in __set_page_dirty_nobuffers Hugh Dickins
2012-06-03 18:15                 ` WARNING: at mm/page-writeback.c:1990 __set_page_dirty_nobuffers+0x13a/0x170() Dave Jones
2012-06-03 18:23                   ` Linus Torvalds
2012-06-03 18:31                     ` Dave Jones
2012-06-03 20:53                       ` Dave Jones
2012-06-03 21:59                         ` Linus Torvalds
2012-06-03 22:13                           ` Dave Jones
2012-06-03 22:29                           ` Hugh Dickins
2012-06-03 22:17                         ` Hugh Dickins
2012-06-03 23:13                           ` Linus Torvalds
2012-06-04  0:46                             ` KOSAKI Motohiro
2012-06-04  1:18                             ` Hugh Dickins
2012-06-04  1:21                             ` Minchan Kim
2012-06-04  1:26                               ` KOSAKI Motohiro
2012-06-04  2:30                                 ` Minchan Kim
2012-06-04  1:10                 ` Minchan Kim
2012-06-04  1:41                   ` Hugh Dickins
2012-06-04  1:47                     ` KOSAKI Motohiro
2012-06-04  2:28                     ` Minchan Kim
2012-06-04  4:21                       ` KOSAKI Motohiro
2012-06-04 13:37                       ` Bartlomiej Zolnierkiewicz
2012-06-01 16:16       ` Markus Trippelsdorf
2012-06-01 16:28         ` Linus Torvalds
2012-06-01 16:39           ` Markus Trippelsdorf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FC88299.1040707@gmail.com \
    --to=kosaki.motohiro@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=amwang@redhat.com \
    --cc=davej@redhat.com \
    --cc=hughd@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).