From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx108.postini.com [74.125.245.108]) by kanga.kvack.org (Postfix) with SMTP id 8DA0C6B0062 for ; Mon, 11 Jun 2012 17:19:44 -0400 (EDT) Received: by dakp5 with SMTP id p5so7299660dak.14 for ; Mon, 11 Jun 2012 14:19:43 -0700 (PDT) Message-ID: <4FD660EC.2010608@gmail.com> Date: Mon, 11 Jun 2012 17:19:40 -0400 From: KOSAKI Motohiro MIME-Version: 1.0 Subject: Re: [PATCH] mm: fix protection column misplacing in /proc/zoneinfo References: <1339422650-9798-1-git-send-email-kosaki.motohiro@gmail.com> <4FD60127.1000805@jp.fujitsu.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Christoph Lameter Cc: KOSAKI Motohiro , David Rientjes , linux-kernel@vger.kernel.org, linux-mm@kvack.org, kosaki.motohiro@gmail.com (6/11/12 5:04 PM), Christoph Lameter wrote: > On Mon, 11 Jun 2012, KOSAKI Motohiro wrote: > >> Several years, some one added ZVC stat. therefore, hardcoded line > > You are talking to the "some one".... The aim at that point was not the > beauty of the output but the scaling of the counter operations. There was > no intention in placing things a certain way. I'd be fine with changes as > long as we are sure that they do not break anything. Maybe my english was poor. I didn't talk about your change at last mail. I talked about some new counters like nr_anon_transparent_hugepages. Hardcoded linenuber assumption was break multiple times already. therefore, I don't think line number change causes application breakage. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org