From: Minchan Kim <minchan@kernel.org>
To: Seth Jennings <sjenning@linux.vnet.ibm.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Nitin Gupta <ngupta@vflare.org>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: Re: [PATCH] staging: zsmalloc: fix uninit'ed variable warning
Date: Thu, 14 Jun 2012 10:35:36 +0900 [thread overview]
Message-ID: <4FD93FE8.1030102@kernel.org> (raw)
In-Reply-To: <1339621422-8449-1-git-send-email-sjenning@linux.vnet.ibm.com>
Hi Seth,
On 06/14/2012 06:03 AM, Seth Jennings wrote:
> This patch fixes an uninitialized variable warning in
> alloc_zspage(). It also fixes the secondary issue of
> prev_page leaving scope on each loop iteration. The only
> reason this ever worked was because prev_page was occupying
> the same space on the stack on each iteration.
>
> Signed-off-by: Seth Jennings <sjenning@linux.vnet.ibm.com>
Nice catch!
Acked-by: Minchan Kim <minchan@kernel.org>
Nitpick:
I can't see the warning.
My gcc version is gcc (Ubuntu/Linaro 4.6.3-1ubuntu5) 4.6.3.
Please, Cced linux-mm, too.
Some guys in mm might have a interest in zsmalloc. :)
--
Kind regards,
Minchan Kim
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next parent reply other threads:[~2012-06-14 1:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1339621422-8449-1-git-send-email-sjenning@linux.vnet.ibm.com>
2012-06-14 1:35 ` Minchan Kim [this message]
2012-06-14 14:13 ` [PATCH] staging: zsmalloc: fix uninit'ed variable warning Seth Jennings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FD93FE8.1030102@kernel.org \
--to=minchan@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ngupta@vflare.org \
--cc=sjenning@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).