Re: [PATCH] staging: zsmalloc: fix uninit'ed variable warning

Re: [PATCH] staging: zsmalloc: fix uninit'ed variable warning

[Minchan Kim]

Hi Seth,

On 06/14/2012 06:03 AM, Seth Jennings wrote:

> This patch fixes an uninitialized variable warning in
> alloc_zspage().  It also fixes the secondary issue of
> prev_page leaving scope on each loop iteration.  The only
> reason this ever worked was because prev_page was occupying
> the same space on the stack on each iteration.
> 
> Signed-off-by: Seth Jennings <sjenning@linux.vnet.ibm.com>


Nice catch!

Acked-by: Minchan Kim <minchan@kernel.org>

Nitpick:
I can't see the warning.
My gcc version is gcc (Ubuntu/Linaro 4.6.3-1ubuntu5) 4.6.3.

Please, Cced linux-mm, too.
Some guys in mm might have a interest in zsmalloc. :)

-- 
Kind regards,
Minchan Kim

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [PATCH] staging: zsmalloc: fix uninit'ed variable warning

[Seth Jennings]

On 06/13/2012 08:35 PM, Minchan Kim wrote:

> Nice catch!


by Andrew!

> Nitpick:
> I can't see the warning.
> My gcc version is gcc (Ubuntu/Linaro 4.6.3-1ubuntu5) 4.6.3.


I couldn't either but Andrew could and he verified the fix.

Not sure what gcc version he is running.

> Please, Cced linux-mm, too.
> Some guys in mm might have a interest in zsmalloc. :)


Meant to include linux-mm :-/  I'll be sure to include
them in future zsmalloc patches.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>