* Re: [PATCH] staging: zsmalloc: fix uninit'ed variable warning [not found] <1339621422-8449-1-git-send-email-sjenning@linux.vnet.ibm.com> @ 2012-06-14 1:35 ` Minchan Kim 2012-06-14 14:13 ` Seth Jennings 0 siblings, 1 reply; 2+ messages in thread From: Minchan Kim @ 2012-06-14 1:35 UTC (permalink / raw) To: Seth Jennings Cc: Greg Kroah-Hartman, Nitin Gupta, Konrad Rzeszutek Wilk, devel, linux-kernel, Andrew Morton, linux-mm@kvack.org Hi Seth, On 06/14/2012 06:03 AM, Seth Jennings wrote: > This patch fixes an uninitialized variable warning in > alloc_zspage(). It also fixes the secondary issue of > prev_page leaving scope on each loop iteration. The only > reason this ever worked was because prev_page was occupying > the same space on the stack on each iteration. > > Signed-off-by: Seth Jennings <sjenning@linux.vnet.ibm.com> Nice catch! Acked-by: Minchan Kim <minchan@kernel.org> Nitpick: I can't see the warning. My gcc version is gcc (Ubuntu/Linaro 4.6.3-1ubuntu5) 4.6.3. Please, Cced linux-mm, too. Some guys in mm might have a interest in zsmalloc. :) -- Kind regards, Minchan Kim -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: zsmalloc: fix uninit'ed variable warning 2012-06-14 1:35 ` [PATCH] staging: zsmalloc: fix uninit'ed variable warning Minchan Kim @ 2012-06-14 14:13 ` Seth Jennings 0 siblings, 0 replies; 2+ messages in thread From: Seth Jennings @ 2012-06-14 14:13 UTC (permalink / raw) To: Minchan Kim Cc: Greg Kroah-Hartman, Nitin Gupta, Konrad Rzeszutek Wilk, devel, linux-kernel, Andrew Morton, linux-mm@kvack.org On 06/13/2012 08:35 PM, Minchan Kim wrote: > Nice catch! by Andrew! > Nitpick: > I can't see the warning. > My gcc version is gcc (Ubuntu/Linaro 4.6.3-1ubuntu5) 4.6.3. I couldn't either but Andrew could and he verified the fix. Not sure what gcc version he is running. > Please, Cced linux-mm, too. > Some guys in mm might have a interest in zsmalloc. :) Meant to include linux-mm :-/ I'll be sure to include them in future zsmalloc patches. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-06-14 14:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1339621422-8449-1-git-send-email-sjenning@linux.vnet.ibm.com>
2012-06-14 1:35 ` [PATCH] staging: zsmalloc: fix uninit'ed variable warning Minchan Kim
2012-06-14 14:13 ` Seth Jennings
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).