* [PATCH] mm/compaction: cleanup on compaction_deferred
@ 2012-06-14 1:19 Gavin Shan
2012-06-14 7:07 ` Minchan Kim
2012-06-14 8:50 ` Johannes Weiner
0 siblings, 2 replies; 3+ messages in thread
From: Gavin Shan @ 2012-06-14 1:19 UTC (permalink / raw)
To: linux-mm; +Cc: rientjes, hannes, akpm, Gavin Shan
When CONFIG_COMPACTION is enabled, compaction_deferred() tries
to recalculate the deferred limit again, which isn't necessary.
When CONFIG_COMPACTION is disabled, compaction_deferred() should
return "true" or "false" since it has "bool" for its return value.
Signed-off-by: Gavin Shan <shangw@linux.vnet.ibm.com>
---
include/linux/compaction.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/compaction.h b/include/linux/compaction.h
index 51a90b7..133ddcf 100644
--- a/include/linux/compaction.h
+++ b/include/linux/compaction.h
@@ -58,7 +58,7 @@ static inline bool compaction_deferred(struct zone *zone, int order)
if (++zone->compact_considered > defer_limit)
zone->compact_considered = defer_limit;
- return zone->compact_considered < (1UL << zone->compact_defer_shift);
+ return zone->compact_considered < defer_limit;
}
#else
@@ -85,7 +85,7 @@ static inline void defer_compaction(struct zone *zone, int order)
static inline bool compaction_deferred(struct zone *zone, int order)
{
- return 1;
+ return true;
}
#endif /* CONFIG_COMPACTION */
--
1.7.9.5
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] mm/compaction: cleanup on compaction_deferred
2012-06-14 1:19 [PATCH] mm/compaction: cleanup on compaction_deferred Gavin Shan
@ 2012-06-14 7:07 ` Minchan Kim
2012-06-14 8:50 ` Johannes Weiner
1 sibling, 0 replies; 3+ messages in thread
From: Minchan Kim @ 2012-06-14 7:07 UTC (permalink / raw)
To: Gavin Shan; +Cc: linux-mm, rientjes, hannes, akpm, Mel Gorman
On 06/14/2012 10:19 AM, Gavin Shan wrote:
> When CONFIG_COMPACTION is enabled, compaction_deferred() tries
> to recalculate the deferred limit again, which isn't necessary.
>
> When CONFIG_COMPACTION is disabled, compaction_deferred() should
> return "true" or "false" since it has "bool" for its return value.
>
> Signed-off-by: Gavin Shan <shangw@linux.vnet.ibm.com>
Acked-by: Minchan Kim <minchan@kernel.org>
--
Kind regards,
Minchan Kim
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mm/compaction: cleanup on compaction_deferred
2012-06-14 1:19 [PATCH] mm/compaction: cleanup on compaction_deferred Gavin Shan
2012-06-14 7:07 ` Minchan Kim
@ 2012-06-14 8:50 ` Johannes Weiner
1 sibling, 0 replies; 3+ messages in thread
From: Johannes Weiner @ 2012-06-14 8:50 UTC (permalink / raw)
To: Gavin Shan; +Cc: linux-mm, rientjes, akpm
On Thu, Jun 14, 2012 at 09:19:13AM +0800, Gavin Shan wrote:
> When CONFIG_COMPACTION is enabled, compaction_deferred() tries
> to recalculate the deferred limit again, which isn't necessary.
>
> When CONFIG_COMPACTION is disabled, compaction_deferred() should
> return "true" or "false" since it has "bool" for its return value.
>
> Signed-off-by: Gavin Shan <shangw@linux.vnet.ibm.com>
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-06-14 8:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-06-14 1:19 [PATCH] mm/compaction: cleanup on compaction_deferred Gavin Shan
2012-06-14 7:07 ` Minchan Kim
2012-06-14 8:50 ` Johannes Weiner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).