[PATCH] mm/buddy: make skip_free_areas_node static

[PATCH] mm/buddy: make skip_free_areas_node static

[Gavin Shan]

Currently, function skip_free_areas_node() seems to be used only
by page allocator, so make it into static one.

Signed-off-by: Gavin Shan <shangw@linux.vnet.ibm.com>
---
 include/linux/mm.h |    1 -
 mm/page_alloc.c    |    2 +-
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/include/linux/mm.h b/include/linux/mm.h
index b36d08c..f660ed7 100644
--- a/include/linux/mm.h
+++ b/include/linux/mm.h
@@ -871,7 +871,6 @@ extern void pagefault_out_of_memory(void);
 #define SHOW_MEM_FILTER_NODES	(0x0001u)	/* filter disallowed nodes */
 
 extern void show_free_areas(unsigned int flags);
-extern bool skip_free_areas_node(unsigned int flags, int nid);
 
 int shmem_zero_setup(struct vm_area_struct *);
 
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 7892f84..3d8d9e7 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -2738,7 +2738,7 @@ void si_meminfo_node(struct sysinfo *val, int nid)
  * Determine whether the node should be displayed or not, depending on whether
  * SHOW_MEM_FILTER_NODES was passed to show_free_areas().
  */
-bool skip_free_areas_node(unsigned int flags, int nid)
+static bool skip_free_areas_node(unsigned int flags, int nid)
 {
 	bool ret = false;
 	unsigned int cpuset_mems_cookie;
-- 
1.7.9.5

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [PATCH] mm/buddy: make skip_free_areas_node static

[Minchan Kim]

On 06/14/2012 03:53 PM, Gavin Shan wrote:

> Currently, function skip_free_areas_node() seems to be used only
> by page allocator, so make it into static one.
> 


barrios@bbox:~/linux-next$ grep -nRH 'skip_free_areas_node' arch/ia64/
arch/ia64/mm/discontig.c:633:		if (skip_free_areas_node(filter, nid))
arch/ia64/mm/contig.c:56:		if (skip_free_areas_node(filter, nid))

-- 
Kind regards,
Minchan Kim

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [PATCH] mm/buddy: make skip_free_areas_node static

[Gavin Shan]

>> Currently, function skip_free_areas_node() seems to be used only
>> by page allocator, so make it into static one.
>> 
>
>
>barrios@bbox:~/linux-next$ grep -nRH 'skip_free_areas_node' arch/ia64/
>arch/ia64/mm/discontig.c:633:		if (skip_free_areas_node(filter, nid))
>arch/ia64/mm/contig.c:56:		if (skip_free_areas_node(filter, nid))
>

Thanks for pointing it out, Minchan.

Thanks,
Gavin

>-- 
>Kind regards,
>Minchan Kim
>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>