From: Glauber Costa <glommer@parallels.com>
To: Christoph Lameter <cl@linux.com>
Cc: linux-mm@kvack.org, Pekka Enberg <penberg@kernel.org>,
David Rientjes <rientjes@google.com>,
cgroups@vger.kernel.org, devel@openvz.org,
Pekka Enberg <penberg@cs.helsinki.fi>
Subject: Re: [PATCH 4/4] make CFLGS_OFF_SLAB visible for all slabs
Date: Thu, 14 Jun 2012 20:01:31 +0400 [thread overview]
Message-ID: <4FDA0ADB.2010508@parallels.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1206141019010.32075@router.home>
On 06/14/2012 07:19 PM, Christoph Lameter wrote:
> On Thu, 14 Jun 2012, Glauber Costa wrote:
>
>> Since we're now moving towards a unified slab allocator interface,
>> make CFLGS_OFF_SLAB visible to all allocators, even though SLAB keeps
>> being its only users. Also, make the name consistent with the other
>> flags, that start with SLAB_xx.
>
> What is the significance of knowledge about internal slab structures (such
> as the CFGLFS_OFF_SLAB) outside of the allocators?
I want to mask that out in kmem-specific slab creation. Since I am
copying the original flags, and that flag is embedded in the slab saved
flags, it will be carried to the new slab if I don't mask it out.
Alternatively to this, I can tweak slab.c to always mask out this at the
beginning of cache creation, if you so prefer.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-06-14 16:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-14 12:17 [PATCH 0/4] Proposed slab patches as basis for memcg Glauber Costa
2012-06-14 12:17 ` [PATCH 1/4] slab: rename gfpflags to allocflags Glauber Costa
2012-06-14 12:17 ` [PATCH 2/4] provide a common place for initcall processing in kmem_cache Glauber Costa
2012-06-14 12:17 ` [PATCH 3/4] slab: move FULL state transition to an initcall Glauber Costa
2012-06-14 12:17 ` [PATCH 4/4] make CFLGS_OFF_SLAB visible for all slabs Glauber Costa
2012-06-14 15:19 ` Christoph Lameter
2012-06-14 16:01 ` Glauber Costa [this message]
2012-06-14 17:29 ` Christoph Lameter
2012-07-02 10:57 ` Glauber Costa
2012-07-02 10:52 ` [PATCH 0/4] Proposed slab patches as basis for memcg Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FDA0ADB.2010508@parallels.com \
--to=glommer@parallels.com \
--cc=cgroups@vger.kernel.org \
--cc=cl@linux.com \
--cc=devel@openvz.org \
--cc=linux-mm@kvack.org \
--cc=penberg@cs.helsinki.fi \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).