From: Minchan Kim <minchan@kernel.org>
To: KOSAKI Motohiro <kosaki.motohiro@gmail.com>
Cc: Kamezawa Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Aaditya Kumar <aaditya.kumar.30@gmail.com>,
Mel Gorman <mel@csn.ul.ie>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: Accounting problem of MIGRATE_ISOLATED freed page
Date: Mon, 25 Jun 2012 10:19:41 +0900 [thread overview]
Message-ID: <4FE7BCAD.4090002@kernel.org> (raw)
In-Reply-To: <4FE530F7.1060108@gmail.com>
On 06/23/2012 11:59 AM, KOSAKI Motohiro wrote:
>
> One more.
>
>
>> +/*
>> + * NOTE:
>> + * Don't use set_pageblock_migratetype(page, MIGRATE_ISOLATE) direclty.
>> + * Instead, use {un}set_pageblock_isolate.
>> + */
>> void set_pageblock_migratetype(struct page *page, int migratetype)
>> {
>> if (unlikely(page_group_by_mobility_disabled))
>
> I don't think we need this comment. please just add BUG_ON.
It adds new condition check in __rmqueue_fallback.
If it's okay, no problem.
But as you know, calling MIGRATE_ISOLATE is very very rare and we can
make sure it's no problem on existing code. So the problem is future
user and I hope they can look at the code comment before using and we mm
have strong review system rather than other subsystem, I believe. :)
If you can't agree, I am willing to add BUG_ON but not sure others
like it. (Especially, Mel).
--
Kind regards,
Minchan Kim
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-06-25 1:19 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-20 6:12 Accounting problem of MIGRATE_ISOLATED freed page Minchan Kim
2012-06-20 6:32 ` KOSAKI Motohiro
2012-06-20 7:53 ` Minchan Kim
2012-06-20 12:44 ` Hillf Danton
2012-06-20 23:58 ` Minchan Kim
2012-06-20 20:19 ` KOSAKI Motohiro
2012-06-21 0:01 ` Minchan Kim
2012-06-21 1:39 ` KOSAKI Motohiro
2012-06-21 1:55 ` Minchan Kim
2012-06-21 2:45 ` KOSAKI Motohiro
2012-06-21 4:55 ` Minchan Kim
2012-06-21 10:52 ` Kamezawa Hiroyuki
2012-06-21 17:22 ` KOSAKI Motohiro
2012-06-22 1:05 ` Minchan Kim
2012-06-22 6:45 ` Minchan Kim
2012-06-23 2:56 ` KOSAKI Motohiro
2012-06-25 1:10 ` Minchan Kim
2012-06-23 2:59 ` KOSAKI Motohiro
2012-06-25 1:19 ` Minchan Kim [this message]
2012-06-23 4:38 ` Kamezawa Hiroyuki
2012-06-25 1:01 ` Minchan Kim
2012-06-25 4:18 ` Minchan Kim
2012-06-22 7:22 ` KOSAKI Motohiro
2012-06-22 7:56 ` Aaditya Kumar
2012-06-22 8:13 ` KOSAKI Motohiro
2012-06-21 11:02 ` Aaditya Kumar
2012-06-22 1:20 ` Minchan Kim
2012-06-22 2:08 ` Aaditya Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FE7BCAD.4090002@kernel.org \
--to=minchan@kernel.org \
--cc=aaditya.kumar.30@gmail.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kosaki.motohiro@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).