From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx171.postini.com [74.125.245.171]) by kanga.kvack.org (Postfix) with SMTP id 345076B02E4 for ; Mon, 25 Jun 2012 03:37:23 -0400 (EDT) Received: by vbkv13 with SMTP id v13so2301559vbk.14 for ; Mon, 25 Jun 2012 00:37:22 -0700 (PDT) Message-ID: <4FE81531.90500@gmail.com> Date: Mon, 25 Jun 2012 03:37:21 -0400 From: KOSAKI Motohiro MIME-Version: 1.0 Subject: Re: [patch] mm, oom: replace some information in tasklist dump References: <4FE50B81.5080603@gmail.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: David Rientjes Cc: KOSAKI Motohiro , KOSAKI Motohiro , Andrew Morton , KAMEZAWA Hiroyuki , linux-mm@kvack.org (6/24/12 4:43 PM), David Rientjes wrote: > On Fri, 22 Jun 2012, KOSAKI Motohiro wrote: > >>>> No worth to make fragile ABI. Do you have any benefit? >>>> >>> >>> Yes, because this is exactly where we would discover something like a >>> mm->nr_ptes accounting issue since it would result in an oom kill and we'd >>> notice the mismatch between nr_ptes and rss in the tasklist dump. >> >> Below patch is better, then. tasklist dump should show brief summary and >> final killed process output should show most detail info. And, now all of >> get_mm_rss() callsite got consistent. >> > > No, it's not. > > Your patch is factoring ptes into get_mm_rss() throughout the kernel, my > patch is showing get_mm_rss() and nr_ptes in the oom killer tasklist dump > since they are both (currently) factored in seperately. They are two > functionally different changes. I said they should not showed separetly. That's all. Don't request talk the same repeat. > If you want to factor ptes into get_mm_rss() and make that change > throughout the kernel, then you should patch linux-next which includes my > oom patch, write an actual changelog for why ptes should now be included > in get_mm_rss() -- which I'll nack because it significantly changes > /proc/pid/stat output for applications between kernel versions that we > depend very heavily on -- and propose it seperately. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org